From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Christoph Hellwig <hch@infradead.org>, Albert Fluegel <af@muc.de>,
linux-nfs@vger.kernel.org
Subject: Re: Bugs / Patch in nfsd
Date: Mon, 18 Nov 2013 09:23:15 -0800 [thread overview]
Message-ID: <20131118172315.GA20339@infradead.org> (raw)
In-Reply-To: <20131118170132.GD3203@fieldses.org>
On Mon, Nov 18, 2013 at 12:01:32PM -0500, J. Bruce Fields wrote:
> Just tracing a v3 mount I can confirm that S_IFDIR (0x4000, 040000)
> gets set in GETATTR replies.
Oh. got it. We set the stat file type, nothing related to the 32-bit
readdir cookie.
> Anyway, absent objections my default is to queue this up for 3.14 (using
> S_IALLUGO).
Yeah, that part looks good to me. But it seem Albert still has an issue
with the directory offsets. Might be worth to get the ext4 developes
in the loop for that, as I doubt it's an issue with the nfsd code.
next prev parent reply other threads:[~2013-11-18 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 12:44 Bugs / Patch in nfsd Albert Fluegel
2013-11-18 13:00 ` Christoph Hellwig
2013-11-18 17:01 ` J. Bruce Fields
2013-11-18 17:23 ` Christoph Hellwig [this message]
2013-11-18 17:37 ` J. Bruce Fields
2013-11-18 17:47 ` Christoph Hellwig
2013-11-20 16:28 ` Albert Fluegel
2013-11-20 16:45 ` J. Bruce Fields
2013-11-18 17:28 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118172315.GA20339@infradead.org \
--to=hch@infradead.org \
--cc=af@muc.de \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).