From: Minlan Wang <wangminlan@huawei.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: <linux-nfs@vger.kernel.org>
Subject: Re: 3.12-rc2 nfsd oops in nfsd_cache_lookup
Date: Wed, 4 Dec 2013 08:55:57 +0800 [thread overview]
Message-ID: <20131204005557.GA18253@f18.localdomain> (raw)
In-Reply-To: <20131203055938.582db322@tlielax.poochiereds.net>
On Tue, Dec 03, 2013 at 05:59:38AM -0500, Jeff Layton wrote:
>
> Actually, it's pretty unlikely that this would get pruned here.
> lru_put_end updates the timestamp on the entry, so the
> prune_cache_entries run would have to take more than 120s and prune
> everything off of the list.
>
> The real bug is that we can later find the entry in the hash that we
> intend to reuse and then free that cache entry. The safe thing to do
> here is to just unhash the entry that we intend to use so that it can't
> be found or pruned.
>
> I sent a patch that should fix this the correct way:
>
> [PATCH] nfsd: when reusing an existing repcache entry, unhash it first
>
Yes, you are right. Thanks.
prev parent reply other threads:[~2013-12-04 1:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 10:29 3.12-rc2 nfsd oops in nfsd_cache_lookup Christoph Hellwig
2013-12-02 17:22 ` Jeff Layton
2013-12-02 17:25 ` Christoph Hellwig
2013-12-03 3:33 ` Minlan Wang
2013-12-03 10:59 ` Jeff Layton
2013-12-04 0:55 ` Minlan Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204005557.GA18253@f18.localdomain \
--to=wangminlan@huawei.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).