From: Jeff Layton <jlayton@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
gartim@gmail.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: when reusing an existing repcache entry, unhash it first
Date: Wed, 4 Dec 2013 13:43:57 -0500 [thread overview]
Message-ID: <20131204134357.6de3ae51@corrin.poochiereds.net> (raw)
In-Reply-To: <20131204170602.GA13308@infradead.org>
On Wed, 4 Dec 2013 09:06:02 -0800
Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Dec 04, 2013 at 12:06:16PM -0500, Jeff Layton wrote:
> > That is another tricky question. Currently, we size the number of hash
> > buckets based on the max size of the cache. If we allow it to grow
> > without bound, then how do we determine how many hash buckets we need?
>
> It won't grow without bound as long as it's trimmed below the size
> by both the periodic workqueue and the shrinker.
>
Right, but we don't know a priori how big the cache can grow, so that
makes determining the number of buckets to allocate a little tricky.
> Of course replacing the hash with an autoscaling data structure would be
> useful, but given that 4.1 obsoletes the DRC I'm not sure how much
> effort we want to put into it.
Agreed.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2013-12-04 18:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 20:26 [PATCH] nfsd: when reusing an existing repcache entry, unhash it first Jeff Layton
2013-12-03 10:25 ` Christoph Hellwig
2013-12-03 18:21 ` Jeff Layton
2013-12-04 8:33 ` Christoph Hellwig
2013-12-04 12:54 ` Jeff Layton
2013-12-04 13:09 ` Christoph Hellwig
2013-12-04 13:31 ` Jeff Layton
2013-12-04 13:40 ` Christoph Hellwig
2013-12-04 13:45 ` Jeff Layton
2013-12-04 13:54 ` Christoph Hellwig
2013-12-04 14:15 ` Jeff Layton
2013-12-04 14:25 ` J. Bruce Fields
2013-12-04 17:06 ` Jeff Layton
2013-12-04 17:06 ` Christoph Hellwig
2013-12-04 18:43 ` Jeff Layton [this message]
2013-12-03 15:50 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204134357.6de3ae51@corrin.poochiereds.net \
--to=jlayton@redhat.com \
--cc=bfields@fieldses.org \
--cc=gartim@gmail.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).