* [PATCH v1] net/sunrpc/cache: simplify code by using hex_pack_byte()
@ 2013-12-12 13:49 Andy Shevchenko
2013-12-12 16:00 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2013-12-12 13:49 UTC (permalink / raw)
To: netdev, David S. Miller, linux-nfs, Trond Myklebust; +Cc: Andy Shevchenko
hex_pack_byte() is a fast way to convert a byte in its ASCII representation. We
may use it instead of custom approach.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
net/sunrpc/cache.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index a72de07..0877db0 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -1111,9 +1111,7 @@ void qword_addhex(char **bpp, int *lp, char *buf, int blen)
*bp++ = 'x';
len -= 2;
while (blen && len >= 2) {
- unsigned char c = *buf++;
- *bp++ = '0' + ((c&0xf0)>>4) + (c>=0xa0)*('a'-'9'-1);
- *bp++ = '0' + (c&0x0f) + ((c&0x0f)>=0x0a)*('a'-'9'-1);
+ bp = hex_byte_pack(bp, *buf++);
len -= 2;
blen--;
}
--
1.8.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] net/sunrpc/cache: simplify code by using hex_pack_byte()
2013-12-12 13:49 [PATCH v1] net/sunrpc/cache: simplify code by using hex_pack_byte() Andy Shevchenko
@ 2013-12-12 16:00 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2013-12-12 16:00 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: netdev, David S. Miller, linux-nfs, Trond Myklebust
On Thu, Dec 12, 2013 at 03:49:21PM +0200, Andy Shevchenko wrote:
> hex_pack_byte() is a fast way to convert a byte in its ASCII representation. We
> may use it instead of custom approach.
Thanks, I'll take that through the nfsd tree for 3.14.
--b.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> net/sunrpc/cache.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index a72de07..0877db0 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -1111,9 +1111,7 @@ void qword_addhex(char **bpp, int *lp, char *buf, int blen)
> *bp++ = 'x';
> len -= 2;
> while (blen && len >= 2) {
> - unsigned char c = *buf++;
> - *bp++ = '0' + ((c&0xf0)>>4) + (c>=0xa0)*('a'-'9'-1);
> - *bp++ = '0' + (c&0x0f) + ((c&0x0f)>=0x0a)*('a'-'9'-1);
> + bp = hex_byte_pack(bp, *buf++);
> len -= 2;
> blen--;
> }
> --
> 1.8.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-12 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-12 13:49 [PATCH v1] net/sunrpc/cache: simplify code by using hex_pack_byte() Andy Shevchenko
2013-12-12 16:00 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).