From: Christoph Hellwig <hch@infradead.org>
To: Benny Halevy <bhalevy@primarydata.com>
Cc: bfields@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] nfsd4: ignore nfsv4.1 lockowners in nfsd4_release_lockowner
Date: Fri, 13 Dec 2013 06:12:43 -0800 [thread overview]
Message-ID: <20131213141243.GA20399@infradead.org> (raw)
In-Reply-To: <1386929026-12627-1-git-send-email-bhalevy@primarydata.com>
> list_for_each_entry(sop, &nn->ownerstr_hashtbl[hashval], so_strhash) {
> if (sop->so_is_open_owner)
> continue;
> + if (sop->so_client->cl_minorversion)
> + continue;
> if (!same_owner_str(sop, owner, clid))
> continue;
> list_for_each_entry(stp, &sop->so_stateids,
This needs at least a good comment as it's not very obvious from
glancing over the code. That being said is same_owner_str so much
overhead that it's really worth it?
next prev parent reply other threads:[~2013-12-13 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 10:01 [PATCH 0/2] a couple fixes in nfsd4_release_lockowner Benny Halevy
2013-12-13 10:03 ` [PATCH 1/2] nfsd4: break from inner lookup loop in nfsd4_release_lockowner on first match Benny Halevy
2013-12-13 14:44 ` J. Bruce Fields
2013-12-13 10:03 ` [PATCH 2/2] nfsd4: ignore nfsv4.1 lockowners in nfsd4_release_lockowner Benny Halevy
2013-12-13 14:12 ` Christoph Hellwig [this message]
2013-12-19 18:57 ` J. Bruce Fields
2013-12-15 15:50 ` [PATCH 0/2] a couple fixes " Benny Halevy
2013-12-15 15:51 ` [PATCH v2 1/2] nfsd4: break from inner lookup loop in nfsd4_release_lockowner on first match Benny Halevy
2013-12-16 15:43 ` Peng Tao
2013-12-17 19:44 ` Benny Halevy
2013-12-20 2:06 ` Peng Tao
2013-12-19 19:32 ` J. Bruce Fields
2013-12-15 15:51 ` [PATCH v2 2/2] nfsd4: ignore nfsv4.1 lockowners in nfsd4_release_lockowner Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213141243.GA20399@infradead.org \
--to=hch@infradead.org \
--cc=bfields@redhat.com \
--cc=bhalevy@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).