From: "J. Bruce Fields" <bfields@redhat.com>
To: Benny Halevy <bhalevy@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] nfsd4: break from inner lookup loop in nfsd4_release_lockowner on first match
Date: Fri, 13 Dec 2013 09:44:58 -0500 [thread overview]
Message-ID: <20131213144458.GA22937@pad.fieldses.org> (raw)
In-Reply-To: <1386929020-12578-1-git-send-email-bhalevy@primarydata.com>
On Fri, Dec 13, 2013 at 12:03:40PM +0200, Benny Halevy wrote:
> Otherwise the lockowner may by added to "matches" more than once.
Whoops, thanks, looks right.
The lo = assignment should probably also be moved up out of this loop.
--b.
>
> Signed-off-by: Benny Halevy <bhalevy@primarydata.com>
> ---
> fs/nfsd/nfs4state.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 0874998..84007b6 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -4660,6 +4660,7 @@ nfsd4_release_lockowner(struct svc_rqst *rqstp,
> if (check_for_locks(stp->st_file, lo))
> goto out;
> list_add(&lo->lo_list, &matches);
> + break;
> }
> }
> /* Clients probably won't expect us to return with some (but not all)
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2013-12-13 14:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 10:01 [PATCH 0/2] a couple fixes in nfsd4_release_lockowner Benny Halevy
2013-12-13 10:03 ` [PATCH 1/2] nfsd4: break from inner lookup loop in nfsd4_release_lockowner on first match Benny Halevy
2013-12-13 14:44 ` J. Bruce Fields [this message]
2013-12-13 10:03 ` [PATCH 2/2] nfsd4: ignore nfsv4.1 lockowners in nfsd4_release_lockowner Benny Halevy
2013-12-13 14:12 ` Christoph Hellwig
2013-12-19 18:57 ` J. Bruce Fields
2013-12-15 15:50 ` [PATCH 0/2] a couple fixes " Benny Halevy
2013-12-15 15:51 ` [PATCH v2 1/2] nfsd4: break from inner lookup loop in nfsd4_release_lockowner on first match Benny Halevy
2013-12-16 15:43 ` Peng Tao
2013-12-17 19:44 ` Benny Halevy
2013-12-20 2:06 ` Peng Tao
2013-12-19 19:32 ` J. Bruce Fields
2013-12-15 15:51 ` [PATCH v2 2/2] nfsd4: ignore nfsv4.1 lockowners in nfsd4_release_lockowner Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213144458.GA22937@pad.fieldses.org \
--to=bfields@redhat.com \
--cc=bhalevy@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).