From: Greg KH <gregkh@linuxfoundation.org>
To: Alexander Aring <alex.aring@gmail.com>
Cc: hannes@stressinduktion.org, linux-nfs@vger.kernel.org,
netdev@vger.kernel.org, stable@vger.kernel.org,
werner@almesberger.net
Subject: Re: [PATCH v2] nfs: fix dead code of ipv6_addr_scope
Date: Tue, 24 Dec 2013 09:35:09 -0800 [thread overview]
Message-ID: <20131224173509.GA24392@kroah.com> (raw)
In-Reply-To: <1387753276-27009-1-git-send-email-alex.aring@gmail.com>
On Mon, Dec 23, 2013 at 12:01:16AM +0100, Alexander Aring wrote:
> This patch corrects the check on a linklocal address.
>
> Currently this can't be work, because ipv6_addr_scope returns a int with
> a mask of IPV6_ADDR_SCOPE_MASK (0x00f0U) and IPV6_ADDR_SCOPE_LINKLOCAL
> is 0x02. So the condition is always false.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> - change check on linklocal address from
> (ipv6_addr_src_scope(&a6->sin6_addr) == IPV6_ADDR_SCOPE_LINKLOCAL) to
> (ipv6_addr_scope(&a6->sin6_addr) & IPV6_ADDR_LINKLOCAL) which is a
> little bit faster.
> - change commit msg.
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
prev parent reply other threads:[~2013-12-24 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 23:01 [PATCH v2] nfs: fix dead code of ipv6_addr_scope Alexander Aring
2013-12-23 3:18 ` Hannes Frederic Sowa
2013-12-24 17:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131224173509.GA24392@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex.aring@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=werner@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).