linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: fix a bug which causing nfsd deny CREATE_SESSION
Date: Fri, 3 Jan 2014 16:34:55 -0500	[thread overview]
Message-ID: <20140103213455.GB5164@fieldses.org> (raw)
In-Reply-To: <52B802E9.4070607@gmail.com>

On Mon, Dec 23, 2013 at 05:31:21PM +0800, Kinglong Mee wrote:
> check_forechannel_attrs have get drc memory, 
> nfsd must put it when check_backchannel_attrs failed.
> 
> After many requests with bad back channel attrs, 
> nfsd will deny any client's CREATE_SESSION forever.

Thanks, applying.--b.

> 
> A new test case named CSESS29 for pynfs will send in another mail.
> 
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
>  fs/nfsd/nfs4state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 105d6fa..4e2c9ba 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1913,7 +1913,7 @@ nfsd4_create_session(struct svc_rqst *rqstp,
>  		return status;
>  	status = check_backchannel_attrs(&cr_ses->back_channel);
>  	if (status)
> -		return status;
> +		goto out_release_drc_mem;
>  	status = nfserr_jukebox;
>  	new = alloc_session(&cr_ses->fore_channel);
>  	if (!new)
> -- 
> 1.8.4.2

      reply	other threads:[~2014-01-03 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23  9:31 [PATCH] NFSD: fix a bug which causing nfsd deny CREATE_SESSION Kinglong Mee
2014-01-03 21:34 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140103213455.GB5164@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=kinglongmee@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).