public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: "Yin.JianHong" <jiyin@redhat.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC] nfs: remove nfs_show_devname
Date: Thu, 9 Jan 2014 14:12:59 -0500	[thread overview]
Message-ID: <20140109141259.553c58f0@tlielax.poochiereds.net> (raw)
In-Reply-To: <6FE57B0D-2373-4B40-BA14-E6F2BF3C44E3@primarydata.com>

On Thu, 9 Jan 2014 14:06:54 -0500
Trond Myklebust <trond.myklebust@primarydata.com> wrote:

> 
> On Jan 9, 2014, at 13:59, Jeff Layton <jlayton@redhat.com> wrote:
> 
> > The nfs code will currently construct a devname to show in places like
> > /proc/mounts by turning a dentry into a path. Unfortunately, that's
> > somewhat problematic if the user ended up mounting through a symlink on
> > the server. The devname that then shows up in /proc/mounts now doesn't
> > match the one that was originally passed into the mount request.
> 
> This is 100% according to design. Why is it suddenly a problem?
> 
> By displaying the original pathname, you also end up bypassing referral resolution, etc. This is exactly why the .show_devname operation was introduced in the first place.
> 

AFAIU, the main issue is that when /etc/mtab is a symlink
to /proc/mounts, you can't do this in the example in the patch
description:

    # mount server:/export/bar /mnt/bar
    # umount server:/export/bar

...since umount will try to ID the mountpoint by looking up the devname
in /etc/mtab. What exactly would this break with referrals?

-- 
Jeff Layton <jlayton@redhat.com>

  reply	other threads:[~2014-01-09 19:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 18:59 [PATCH RFC] nfs: remove nfs_show_devname Jeff Layton
2014-01-09 19:06 ` Trond Myklebust
2014-01-09 19:12   ` Jeff Layton [this message]
2014-01-09 19:27     ` Trond Myklebust
2014-01-09 19:55       ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140109141259.553c58f0@tlielax.poochiereds.net \
    --to=jlayton@redhat.com \
    --cc=jiyin@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox