From: "J. Bruce Fields" <bfields@fieldses.org>
To: Robert Schiele <rschiele@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] use NFS4_MAXMINOR instead of hard coded number
Date: Mon, 27 Jan 2014 09:34:20 -0500 [thread overview]
Message-ID: <20140127143420.GA17165@fieldses.org> (raw)
In-Reply-To: <CAObFj3z9o7QzSk0AOfUZWk1+xv4k6mB9OHtuMC5JjUqvudXL2w@mail.gmail.com>
On Sat, Jan 25, 2014 at 05:23:28AM +0100, Robert Schiele wrote:
> On Fri, Jan 24, 2014 at 8:28 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
> > While we're at it, is there any harm to letting NFS4_MAXMINOR be much
> > higher? That would save the need to rebuild nfs-utils just because you
> > want to test a kernel with new minor version support.
>
> That does not work. This constant is used to generate the string to be
> thrown into the kernel and the kernel complains about items in the
> string it does not know about, even if they are disabled, like "-4.7".
> It would work if at the same time you got a patch into the kernel that
> it no longer complains about unknown items that are disabled.
That's a bug that was fixed by 93648ecc10bae7ed542056abb55f4b8f10ddbbb9
"nfsd: fix minorversion-choosing interface"
--b.
next prev parent reply other threads:[~2014-01-27 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 6:32 [PATCH] use NFS4_MAXMINOR instead of hard coded number Robert Schiele
2014-01-24 19:28 ` J. Bruce Fields
2014-01-25 4:23 ` Robert Schiele
2014-01-27 14:34 ` J. Bruce Fields [this message]
2014-01-27 14:55 ` Robert Schiele
2014-01-27 14:57 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127143420.GA17165@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rschiele@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox