From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-qa0-f52.google.com ([209.85.216.52]:63588 "EHLO mail-qa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbaBCUnY (ORCPT ); Mon, 3 Feb 2014 15:43:24 -0500 Date: Mon, 3 Feb 2014 15:43:19 -0500 From: Tejun Heo To: Trond Myklebust Cc: Dr Fields James Bruce , linuxnfs , Li Zefan , containers@lists.linux-foundation.org, cgroups@vger.kernel.org Subject: Re: [PATCH] nfs: include xattr.h from fs/nfs/nfs3proc.c Message-ID: <20140203204319.GI30250@htj.dyndns.org> References: <20140203193107.GH30250@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Feb 03, 2014 at 02:48:13PM -0500, Trond Myklebust wrote: > > On Feb 3, 2014, at 14:31, Tejun Heo wrote: > > > fs/nfs/nfs3proc.c is making use of xattr but was getting linux/xattr.h > > indirectly through linux/cgroup.h, which will soon drop the inclusion > > of xattr.h. Explicitly include linux/xattr.h from nfs3proc.c so that > > compilation doesn't fail when linux/cgroup.h drops linux/xattr.h. > > > > As the following cgroup changes will depend on these changes, it > > probably would be easier to route this through cgroup branch. Would > > that be okay? > > > > Signed-off-by: Tejun Heo > > Cc: "J. Bruce Fields" > > EWRONGMAINTAINER… :-) > > Acked-by: Trond Myklebust Oopsy, thanks! :) -- tejun