Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Weston Andros Adamson <dros@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH pynfs] nfs4.1 server: DSs should have diff server owners
Date: Tue, 11 Feb 2014 12:08:42 -0500	[thread overview]
Message-ID: <20140211170842.GE19599@fieldses.org> (raw)
In-Reply-To: <1392050222-1470-1-git-send-email-dros@primarydata.com>

On Mon, Feb 10, 2014 at 11:37:02AM -0500, Weston Andros Adamson wrote:
> Use getpid() to generate the minor_id component of the server owner.
> 
> Witout this, all DSs are considered to be the same server by NFS clients
> that detect server trunking, such as the upstream Linux client.

Applied and pushed out, thanks.--b.

> 
> Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
> ---
>  nfs4.1/config.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/nfs4.1/config.py b/nfs4.1/config.py
> index 4f91e84..2238aee 100644
> --- a/nfs4.1/config.py
> +++ b/nfs4.1/config.py
> @@ -3,6 +3,7 @@ from nfs4_const import *
>  import nfs4_const
>  import nfs4lib
>  from copy import deepcopy
> +import os
>  
>  class ConfigAction(Exception):
>      pass
> @@ -129,7 +130,7 @@ class ServerConfig(object):
>                ]
>  
>      def __init__(self):
> -        self.minor_id = 0
> +        self.minor_id = os.getpid()
>          self.major_id = "PyNFSv4.1"
>          self._owner = server_owner4(self.minor_id, self.major_id)
>          self.scope = "Default_Scope"
> -- 
> 1.8.3.4 (Apple Git-47)
> 

      reply	other threads:[~2014-02-11 17:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 16:37 [PATCH pynfs] nfs4.1 server: DSs should have diff server owners Weston Andros Adamson
2014-02-11 17:08 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140211170842.GE19599@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=dros@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox