From: Christoph Hellwig <hch@infradead.org>
To: Anna Schumaker <schumaker.anna@gmail.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] nfs: remove ->write_pageio_init from rpc ops
Date: Wed, 19 Mar 2014 08:40:48 -0700 [thread overview]
Message-ID: <20140319154048.GB3729@infradead.org> (raw)
In-Reply-To: <53299787.5030401@gmail.com>
On Wed, Mar 19, 2014 at 09:11:35AM -0400, Anna Schumaker wrote:
> On 03/19/2014 03:41 AM, Christoph Hellwig wrote:
> > On Tue, Mar 18, 2014 at 02:04:28PM -0400, Anna Schumaker wrote:
> >>> The other option would be to simply always have the pnfs_curr_ld field
> >>> in the server structure and remove the ifdef entirely.
> >> Okay. If we keep the ifdef, then it should probably check for CONFIG_NFS_V4_1 and not CONFIG_NFS_V4
> > The field in the header is under CONFIG_NFS_V4, so I tried to make it
> > consistent.
> >
> struct pnfs_layoutdriver_type comes from fs/nfs/pnfs.h under a CONFIG_NFS_V4_1 check, so you can't access pg_write_ops or pg_read_ops without v4.1 enabled.
You're right - the field exists for plain v4, but we can't dereference
it unless 4.1 support is enable. I'll send an update.
next prev parent reply other threads:[~2014-03-19 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 11:28 [PATCH 1/2] nfs: remove ->write_pageio_init from rpc ops Christoph Hellwig
2014-03-18 11:28 ` [PATHC 2/2] nfs: remove ->read_pageio_init " Christoph Hellwig
2014-03-18 12:49 ` [PATCH 1/2] nfs: remove ->write_pageio_init " Anna Schumaker
2014-03-18 14:09 ` Christoph Hellwig
2014-03-18 18:04 ` Anna Schumaker
2014-03-19 7:41 ` Christoph Hellwig
2014-03-19 13:11 ` Anna Schumaker
2014-03-19 15:40 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-16 13:07 pageio_init simplifications, V2 Christoph Hellwig
2014-04-16 13:07 ` [PATCH 1/2] nfs: remove ->write_pageio_init from rpc ops Christoph Hellwig
2014-04-17 14:50 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319154048.GB3729@infradead.org \
--to=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=schumaker.anna@gmail.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).