Re: [PATCH 01/17] NFS: Create a common argument structure for reads and writes

[Christoph Hellwig <hch@infradead.org>]

>  /*
> + * Arguments shared by the read and write call.
> + */
> +struct nfs_pgio_args {
> +	struct nfs4_sequence_args	seq_args;
> +	struct nfs_fh *		fh;
> +	struct nfs_open_context *context;
> +	struct nfs_lock_context *lock_context;
> +	nfs4_stateid		stateid;
> +	__u64			offset;
> +	__u32			count;
> +	enum nfs3_stable_how	stable;		/* used by write */
> +	unsigned int		pgbase;
> +	struct page **		pages;
> +	const u32 *		bitmask;	/* used by write */
> +};

It might make sense to keep the arguments only used for writes together
at the end of the structure.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>