From: Christoph Hellwig <hch@infradead.org>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 07/17] NFS: Create a common rw_header_alloc and rw_header_free function
Date: Mon, 21 Apr 2014 06:32:52 -0700 [thread overview]
Message-ID: <20140421133252.GA30954@infradead.org> (raw)
In-Reply-To: <1397768981-12856-8-git-send-email-Anna.Schumaker@Netapp.com>
On Thu, Apr 17, 2014 at 05:09:31PM -0400, Anna Schumaker wrote:
> From: Anna Schumaker <Anna.Schumaker@netapp.com>
>
> I create a new struct nfs_rw_ops to decide the differences between reads
> and writes. This struct will be set when initializing a new
> nfs_pgio_descriptor, and then passed on to the nfs_rw_header when a new
> header is allocated.
To me it seems like adding this new vector confuses things. From a look
at your whole tree it seems like all methods added to it could as well
be added to nfs_pageio_ops. In that case we'd still keep separate
instances of nfs_pageio_ops for reads and writes, but most methods would
be that same. I'm also defintively curious what you have on your
sleeves for pnfs.
next prev parent reply other threads:[~2014-04-21 13:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 21:09 [PATCH 00/17] NFS: Create a common path used by reads and writes Anna Schumaker
2014-04-17 21:09 ` [PATCH 01/17] NFS: Create a common argument structure for " Anna Schumaker
2014-04-18 13:56 ` Christoph Hellwig
2014-04-21 12:44 ` Anna Schumaker
2014-04-17 21:09 ` [PATCH 02/17] NFS: Create a common results " Anna Schumaker
2014-04-18 13:57 ` Christoph Hellwig
2014-04-21 12:45 ` Anna Schumaker
2014-04-17 21:09 ` [PATCH 03/17] NFS: Create a common read and write data struct Anna Schumaker
2014-04-18 14:00 ` Christoph Hellwig
2014-04-17 21:09 ` [PATCH 04/17] NFS: Create a common read and write header struct Anna Schumaker
2014-04-18 14:01 ` Christoph Hellwig
2014-04-17 21:09 ` [PATCH 05/17] NFS: Move the write verifier into the nfs_pgio_header Anna Schumaker
2014-04-18 14:02 ` Christoph Hellwig
2014-04-17 21:09 ` [PATCH 06/17] NFS: Create a common pgio_alloc and pgio_release function Anna Schumaker
2014-04-18 14:03 ` Christoph Hellwig
2014-04-17 21:09 ` [PATCH 07/17] NFS: Create a common rw_header_alloc and rw_header_free function Anna Schumaker
2014-04-21 13:32 ` Christoph Hellwig [this message]
2014-04-21 13:52 ` Anna Schumaker
2014-04-21 16:24 ` Anna Schumaker
2014-04-25 12:12 ` Christoph Hellwig
2014-04-25 13:02 ` Anna Schumaker
2014-04-17 21:09 ` [PATCH 08/17] NFS: Create a common pgio_rpc_prepare function Anna Schumaker
2014-04-17 21:09 ` [PATCH 09/17] NFS: Create a common nfs_pgio_result_common function Anna Schumaker
2014-04-17 21:09 ` [PATCH 10/17] NFS: Create a common rpc_call_ops struct Anna Schumaker
2014-04-17 21:09 ` [PATCH 11/17] NFS: Create a common rpcsetup function for reads and writes Anna Schumaker
2014-04-17 21:09 ` [PATCH 12/17] NFS: Create a common pgio_error function Anna Schumaker
2014-04-17 21:09 ` [PATCH 13/17] NFS: Create a generic_pgio function Anna Schumaker
2014-04-17 21:09 ` [PATCH 14/17] NFS: Create a common initiate_pgio() function Anna Schumaker
2014-04-17 21:09 ` [PATCH 15/17] NFS: Create a common multiple_pgios() function Anna Schumaker
2014-04-17 21:09 ` [PATCH 16/17] NFS: Create a common generic_pg_pgios() Anna Schumaker
2014-04-17 21:09 ` [PATCH 17/17] NFS: Create a common nfs_pageio_ops struct Anna Schumaker
2014-04-21 6:42 ` [PATCH 00/17] NFS: Create a common path used by reads and writes Christoph Hellwig
2014-04-21 12:46 ` Anna Schumaker
2014-04-21 13:09 ` Christoph Hellwig
2014-04-23 12:55 ` Boaz Harrosh
2014-04-23 13:15 ` Boaz Harrosh
2014-04-23 13:42 ` Weston Andros Adamson
2014-04-23 13:51 ` Anna Schumaker
2014-04-23 13:59 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421133252.GA30954@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).