From: "J. Bruce Fields" <bfields@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: nfsd4 xdr encoding fixes v2
Date: Mon, 12 May 2014 12:07:41 -0400 [thread overview]
Message-ID: <20140512160740.GE2633@pad.redhat.com> (raw)
In-Reply-To: <20140512082059.GC14194@infradead.org>
On Mon, May 12, 2014 at 01:20:59AM -0700, Christoph Hellwig wrote:
> This series seem to cause hangs during xfstests against a server on the
> same VM. The trace is fairly similar every the hang happens, but the
> point at which it happens differs:
Ouch, OK, and you're sure it starts with this series?
I guess I should try to replicate it here. Might take a copule days.
--b.
>
> [ 3120.186527] INFO: task fill:26222 blocked for more than 120 seconds.
> [ 3120.187607] Not tainted 3.15.0-rc1+ #22
> [ 3120.188424] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
> disables this message.
> [ 3120.189765] fill D ffff88007a5b3c20 0 26222 26130
> 0x00000002
> [ 3120.191158] ffff88007a5b3b78 0000000000000046 ffff880079284f10
> 0000000000013dc0
> [ 3120.192666] ffff88007a5b3fd8 0000000000013dc0 ffff88007350cf10
> ffff880079284f10
> [ 3120.195303] 0000000000000000 0000000000000002 0000000000000001
> 0000000000000000
> [ 3120.197980] Call Trace:
> [ 3120.198849] [<ffffffff8112ff2d>] ? __delayacct_blkio_start+0x1d/0x20
> [ 3120.200791] [<ffffffff810ead35>] ? prepare_to_wait+0x25/0x90
> [ 3120.202438] [<ffffffff811114f5>] ? ktime_get_ts+0x145/0x180
> [ 3120.204033] [<ffffffff8115ef50>] ? __lock_page+0x70/0x70
> [ 3120.205598] [<ffffffff8107c83f>] ? kvm_clock_read+0x1f/0x30
> [ 3120.207236] [<ffffffff8107c859>] ? kvm_clock_get_cycles+0x9/0x10
> [ 3120.209006] [<ffffffff81111464>] ? ktime_get_ts+0xb4/0x180
> [ 3120.210828] [<ffffffff8112ff2d>] ? __delayacct_blkio_start+0x1d/0x20
> [ 3120.212645] [<ffffffff8115ef50>] ? __lock_page+0x70/0x70
> [ 3120.214290] [<ffffffff81ce5294>] schedule+0x24/0x70
> [ 3120.216915] [<ffffffff81ce536a>] io_schedule+0x8a/0xd0
> [ 3120.218484] [<ffffffff8115ef59>] sleep_on_page+0x9/0x10
> [ 3120.219979] [<ffffffff81ce5a8a>] __wait_on_bit+0x5a/0x90
> [ 3120.221543] [<ffffffff8115e9cf>] ? find_get_pages_tag+0x1f/0x190
> [ 3120.223310] [<ffffffff8115f438>] wait_on_page_bit+0x78/0x80
> [ 3120.224934] [<ffffffff810eb240>] ? wake_atomic_t_function+0x30/0x30
> [ 3120.226755] [<ffffffff8115f5a2>] filemap_fdatawait_range+0x102/0x190
> [ 3120.228615] [<ffffffff8116033a>]
> filemap_write_and_wait_range+0x4a/0x80
> [ 3120.230640] [<ffffffff8135c00f>] nfs4_file_fsync+0x5f/0xb0
> [ 3120.232230] [<ffffffff811d70c1>] vfs_fsync+0x21/0x30
> [ 3120.233716] [<ffffffff8132a1fe>] nfs_file_flush+0x6e/0x90
> [ 3120.235261] [<ffffffff811a4ac5>] filp_close+0x35/0x80
> [ 3120.236758] [<ffffffff811c4844>] put_files_struct+0x94/0xe0
> [ 3120.238361] [<ffffffff811c494d>] exit_files+0x4d/0x60
> [ 3120.239863] [<ffffffff810ad947>] do_exit+0x297/0xa00
> [ 3120.241336] [<ffffffff811a91b8>] ? __sb_end_write+0x78/0x80
> [ 3120.242925] [<ffffffff81cea158>] ? retint_swapgs+0x13/0x1b
> [ 3120.244541] [<ffffffff810ae1d7>] do_group_exit+0x47/0xc0
> [ 3120.246129] [<ffffffff810ae262>] SyS_exit_group+0x12/0x20
> [ 3120.247960] [<ffffffff81cf24f9>] system_call_fastpath+0x16/0x1b
> [ 3120.249226] no locks held by fill/26222.
>
next prev parent reply other threads:[~2014-05-12 16:08 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 20:52 nfsd4 xdr encoding fixes v2 J. Bruce Fields
2014-05-11 20:52 ` [PATCH 01/43] nfsd4: embed xdr_stream in nfsd4_compoundres J. Bruce Fields
2014-05-12 5:34 ` Christoph Hellwig
2014-05-16 9:58 ` Kinglong Mee
2014-05-22 15:13 ` J. Bruce Fields
2014-05-11 20:52 ` [PATCH 02/43] nfsd4: tweak nfsd4_encode_getattr to take xdr_stream J. Bruce Fields
2014-05-12 5:35 ` Christoph Hellwig
2014-05-12 16:06 ` J. Bruce Fields
2014-05-11 20:52 ` [PATCH 03/43] nfsd4: move proc_compound xdr encode init to helper J. Bruce Fields
2014-05-12 5:36 ` Christoph Hellwig
2014-05-11 20:52 ` [PATCH 04/43] nfsd4: reserve head space for krb5 integ/priv info J. Bruce Fields
2014-05-12 5:37 ` Christoph Hellwig
2014-05-12 21:45 ` J. Bruce Fields
2014-05-13 5:05 ` Christoph Hellwig
2014-05-13 14:47 ` J. Bruce Fields
2014-05-11 20:52 ` [PATCH 05/43] nfsd4: move nfsd4_operation to xdr4.h J. Bruce Fields
2014-05-12 5:41 ` Christoph Hellwig
2014-05-22 15:56 ` J. Bruce Fields
2014-05-11 20:52 ` [PATCH 06/43] nfsd4: fix encoding of out-of-space replies J. Bruce Fields
2014-05-12 8:18 ` Christoph Hellwig
2014-05-12 21:47 ` J. Bruce Fields
2014-05-11 20:52 ` [PATCH 07/43] nfsd4: allow space for final error return J. Bruce Fields
2014-05-12 8:18 ` Christoph Hellwig
2014-05-12 14:06 ` J. Bruce Fields
2014-05-11 20:52 ` [PATCH 08/43] nfsd4: use xdr_reserve_space in attribute encoding J. Bruce Fields
2014-05-11 20:52 ` [PATCH 09/43] nfsd4: use xdr_stream throughout compound encoding J. Bruce Fields
2014-05-11 20:52 ` [PATCH 10/43] nfsd4: remove ADJUST_ARGS J. Bruce Fields
2014-05-11 20:52 ` [PATCH 11/43] nfsd4: no need for encode_compoundres to adjust lengths J. Bruce Fields
2014-05-11 20:52 ` [PATCH 12/43] nfsd4: keep xdr buf length updated J. Bruce Fields
2014-05-11 20:52 ` [PATCH 13/43] rpc: xdr_truncate_encode J. Bruce Fields
2014-05-11 20:52 ` [PATCH 14/43] nfsd4: use xdr_truncate_encode J. Bruce Fields
2014-05-11 20:52 ` [PATCH 15/43] nfsd4: "backfill" using write_bytes_to_xdr_buf J. Bruce Fields
2014-05-11 20:52 ` [PATCH 16/43] nfsd4: teach encoders to handle reserve_space failures J. Bruce Fields
2014-05-11 20:52 ` [PATCH 17/43] nfsd4: reserve space before inlining 0-copy pages J. Bruce Fields
2014-05-11 20:52 ` [PATCH 18/43] nfsd4: nfsd4_check_resp_size needn't recalculate length J. Bruce Fields
2014-05-11 20:52 ` [PATCH 19/43] nfsd4: remove redundant encode buffer size checking J. Bruce Fields
2014-05-11 20:52 ` [PATCH 20/43] nfsd4: size-checking cleanup J. Bruce Fields
2014-05-11 20:52 ` [PATCH 21/43] nfsd4: allow encoding across page boundaries J. Bruce Fields
2014-05-11 20:52 ` [PATCH 22/43] nfsd4: convert 4.1 replay encoding J. Bruce Fields
2014-05-11 20:52 ` [PATCH 23/43] nfsd4: don't try to encode conflicting owner if low on space J. Bruce Fields
2014-05-11 20:52 ` [PATCH 24/43] nfsd4: more precise nfsd4_max_reply J. Bruce Fields
2014-05-11 20:52 ` [PATCH 25/43] nfsd4: minor encode_read cleanup J. Bruce Fields
2014-05-11 20:52 ` [PATCH 26/43] nfsd4: nfsd4_check_resp_size should check against whole buffer J. Bruce Fields
2014-05-11 20:52 ` [PATCH 27/43] rpc: define xdr_restrict_buflen J. Bruce Fields
2014-05-11 20:52 ` [PATCH 28/43] nfsd4: adjust buflen to session channel limit J. Bruce Fields
2014-05-11 20:52 ` [PATCH 29/43] nfsd4: use session limits to release send buffer reservation J. Bruce Fields
2014-05-11 20:52 ` [PATCH 30/43] nfsd4: allow large readdirs J. Bruce Fields
2014-05-11 20:52 ` [PATCH 31/43] nfsd4: enforce rd_dircount J. Bruce Fields
2014-05-11 20:52 ` [PATCH 32/43] nfsd4: don't treat readlink like a zero-copy operation J. Bruce Fields
2014-05-11 20:52 ` [PATCH 33/43] nfsd4: better estimate of getattr response size J. Bruce Fields
2014-05-11 20:52 ` [PATCH 34/43] nfsd4: estimate sequence " J. Bruce Fields
2014-05-11 20:52 ` [PATCH 35/43] nfsd4: turn off zero-copy-read in exotic cases J. Bruce Fields
2014-05-11 20:52 ` [PATCH 36/43] nfsd4: nfsd_vfs_read doesn't use file handle parameter J. Bruce Fields
2014-05-11 20:52 ` [PATCH 37/43] nfsd4: separate splice and readv cases J. Bruce Fields
2014-05-11 20:52 ` [PATCH 38/43] nfsd4: allow exotic read compounds J. Bruce Fields
2014-05-11 20:52 ` [PATCH 39/43] nfsd4: really fix nfs4err_resource in 4.1 case J. Bruce Fields
2014-05-12 5:33 ` Christoph Hellwig
2014-05-12 14:18 ` J. Bruce Fields
2014-05-11 20:52 ` [PATCH 40/43] nfsd4: kill WRITE32 J. Bruce Fields
2014-05-11 20:52 ` [PATCH 41/43] nfsd4: kill WRITE64 J. Bruce Fields
2014-05-11 20:52 ` [PATCH 42/43] nfsd4: kill WRITEMEM J. Bruce Fields
2014-05-11 20:52 ` [PATCH 43/43] nfsd4: kill write32, write64 J. Bruce Fields
2014-05-12 8:20 ` nfsd4 xdr encoding fixes v2 Christoph Hellwig
2014-05-12 16:07 ` J. Bruce Fields [this message]
2014-05-12 16:11 ` Christoph Hellwig
2014-05-13 11:09 ` Christoph Hellwig
2014-05-13 14:48 ` J. Bruce Fields
2014-05-13 21:18 ` J. Bruce Fields
2014-05-13 21:33 ` J. Bruce Fields
2014-05-22 19:17 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512160740.GE2633@pad.redhat.com \
--to=bfields@redhat.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).