From: Christoph Hellwig <hch@infradead.org>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org,
dros@primarydata.com, hch@infradead.org
Subject: Re: [RFC 00/12] PNFS Read and Write Cleanups
Date: Wed, 21 May 2014 07:23:20 -0700 [thread overview]
Message-ID: <20140521142320.GA12674@infradead.org> (raw)
In-Reply-To: <1400609299-32558-1-git-send-email-Anna.Schumaker@Netapp.com>
On Tue, May 20, 2014 at 02:08:07PM -0400, Anna Schumaker wrote:
> There is a lot of duplicate code in pnfs.c that can be cleaned up to
> share more code. This patch set goes through each function one at a
> time and merges read and write code together wherever possible. In the
> end I'm passing around a few function pointers. Would it be better to
> use a function pointer struct instead?
No chance to share this with the r/w ops for the classic code?
Aso I think it would be even better if a lot of this code could be
mergedinto the classic code path, it seems like we'd mostly need
pnfs_get/put_lseg in common code for this. pnfs_get_lseg is so trivial
that it's not a problem, and the put could be done by simply giving each
lseg a free function pointer.
prev parent reply other threads:[~2014-05-21 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 18:08 [RFC 00/12] PNFS Read and Write Cleanups Anna Schumaker
2014-05-20 18:08 ` [RFC 01/12] nfs: Create a common pnfs_pageio_reset_mds() function Anna Schumaker
2014-05-20 18:08 ` [RFC 02/12] nfs: Create a common pnfs_generic_pg_init() function Anna Schumaker
2014-05-20 18:08 ` [RFC 03/12] nfs: Create a common pnfs_ld_handle_rw_error() function Anna Schumaker
2014-05-20 18:08 ` [RFC 04/12] nfs: Create a common pnfs_ld_rw_done() Anna Schumaker
2014-05-20 18:08 ` [RFC 05/12] nfs: Create a common pnfs_through_mds() function Anna Schumaker
2014-05-20 18:08 ` [RFC 06/12] nfs: merge pnfs_try_to_write_data() and pnfs_do_write() Anna Schumaker
2014-05-20 18:08 ` [RFC 07/12] nfs: merge pnfs_try_to_read_data() and pnfs_do_read() Anna Schumaker
2014-05-20 18:08 ` [RFC 08/12] nfs: create a common pnfs_do_rw() function Anna Schumaker
2014-05-20 18:08 ` [RFC 09/12] nfs: create a common pnfs_pgiohdr_free function Anna Schumaker
2014-05-20 18:08 ` [RFC 10/12] nfs: Split up generic_pg_pgios Anna Schumaker
2014-05-20 18:08 ` [RFC 11/12] nfs: pnfs can use nfs_generic_pgios_common() too! Anna Schumaker
2014-05-20 18:08 ` [RFC 12/12] nfs: Create a common pnfs_generic_rwpages() function Anna Schumaker
2014-05-21 14:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521142320.GA12674@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=dros@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).