Re: [PATCH 4/4] NFSD: Ignore and warn once for more fslocs or more uuids

["J. Bruce Fields" <bfields@fieldses.org>]

On Fri, May 23, 2014 at 08:01:47PM +0800, Kinglong Mee wrote:
> If mountd writes more fslocs or more uuids, just ignore and warn once.

So the current behavior is a leak?

Have you observed any version of mountd actually writing more than one
of these?

If not, I'd prefer to return an error.

--b.

> 
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
>  fs/nfsd/export.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
> index 90d37b6..1d56ae3 100644
> --- a/fs/nfsd/export.c
> +++ b/fs/nfsd/export.c
> @@ -394,6 +394,12 @@ fsloc_parse(char **mesg, char *buf, struct nfsd4_fs_locations *fsloc)
>  	int len;
>  	int migrated, i, err;
>  
> +	/* utils writes more fslocs than one */
> +	if (fsloc->locations) {
> +		WARN_ON_ONCE(1);
> +		return 0;
> +	}
> +
>  	/* listsize */
>  	err = get_uint(mesg, &fsloc->locations_count);
>  	if (err)
> @@ -485,6 +491,12 @@ uuid_parse(char **mesg, char *buf, unsigned char **puuid)
>  {
>  	int len;
>  
> +	/* utils writes more uuid than one */
> +	if (*puuid) {
> +		WARN_ON_ONCE(1);
> +		return 0;
> +	}
> +
>  	/* expect a 16 byte uuid encoded as \xXXXX... */
>  	len = qword_get(mesg, buf, PAGE_SIZE);
>  	if (len != EX_UUID_LEN)
> -- 
> 1.9.0
>