From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: getattr for FATTR4_WORD0_FILES_AVAIL needs the statfs buffer
Date: Wed, 28 May 2014 12:38:02 -0700 [thread overview]
Message-ID: <20140528193802.GA13258@infradead.org> (raw)
In-Reply-To: <20140528193555.GD22210@fieldses.org>
On Wed, May 28, 2014 at 03:35:55PM -0400, J. Bruce Fields wrote:
> Thanks, applying for 3.16 and stable.
>
> But, I don't get it: we've been returning random uninitialized data in
> FILES_AVAIL since forever, and nobody's noticed till now?
>
> Oh, I see: probably every client requests at least one other thing on
> that list at the same time it requests FILES_AVAIL.
Yeah. I only found this when prototyping schemes to split
nfsd4_encode_fattr into easier manageable chunks.
prev parent reply other threads:[~2014-05-28 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 8:46 [PATCH] nfsd: getattr for FATTR4_WORD0_FILES_AVAIL needs the statfs buffer Christoph Hellwig
2014-05-28 19:35 ` J. Bruce Fields
2014-05-28 19:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528193802.GA13258@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).