From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
NFS <linux-nfs@vger.kernel.org>
Subject: Re: Live lock in silly-rename.
Date: Fri, 30 May 2014 17:55:23 -0400 [thread overview]
Message-ID: <20140530215522.GA27615@fieldses.org> (raw)
In-Reply-To: <20140530134442.5a8e5983@notabene.brown>
On Fri, May 30, 2014 at 01:44:42PM +1000, NeilBrown wrote:
> On Thu, 29 May 2014 20:44:23 -0400 "J. Bruce Fields" <bfields@fieldses.org>
> wrote:
>
> > Yes, it's a known server bug.
> >
> > As a first attempt I was thinking of just sticking a timestamp in struct
> > inode to record the time of the most recent conflicting access and deny
> > delegations if the timestamp is too recent, for some definition of too
> > recent.
> >
>
> Hmmm... I'll have a look next week and see what I can come up with.
Thanks!
If we didn't think it was worth another struct inode field, we could
probably get away with global state. Even just refusing to give out any
delegations for a few seconds after any delegation break would be enough
to fix this bug.
Or you could make it a little less harsh with a small hash table: "don't
give out a delegation on any inode whose inode number hashes to X for a
few seconds."
As long as the delegations can be turned down at the whim of the server,
we've got a lot of leeway.
--b.
next prev parent reply other threads:[~2014-05-30 21:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 6:45 Live lock in silly-rename NeilBrown
2014-05-29 16:38 ` Trond Myklebust
[not found] ` <20140530075135.753fb7ed@notabene.brown>
2014-05-30 0:44 ` J. Bruce Fields
2014-05-30 3:44 ` NeilBrown
2014-05-30 21:55 ` J. Bruce Fields [this message]
2014-05-30 22:13 ` NeilBrown
2014-06-04 7:39 ` NeilBrown
2014-06-04 12:48 ` Trond Myklebust
2014-06-04 13:27 ` J. Bruce Fields
2014-06-05 0:26 ` NeilBrown
2014-06-05 0:40 ` NeilBrown
2014-06-04 22:05 ` J. Bruce Fields
2014-06-05 0:34 ` NeilBrown
2014-06-11 14:21 ` J. Bruce Fields
2014-06-12 1:43 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530215522.GA27615@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).