linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs: commit layouts in fdatasync
Date: Mon, 2 Jun 2014 01:19:40 -0700	[thread overview]
Message-ID: <20140602081940.GA32300@infradead.org> (raw)
In-Reply-To: <CAHQdGtSKHRt3DZad9ezvF0Wx+i5SfQuJTHzHUOOwdgi1GoscKw@mail.gmail.com>

On Wed, May 28, 2014 at 07:00:08PM -0400, Trond Myklebust wrote:
> Applied for 3.16. Not sure about -stable eligibility, since this only
> affects pnfs blocks for now (files and objects should both be able to
> recover in case of client failure).

At least the linux-nfs.org object server needs the layoutcommit to
update i_size on the inode, so changes won't be persistent without the
layoutcommit.  I expect loosely coupled file servers to work in a
similar fashion.

> Are you seeing this in production
> environments?

This was found during data integrity testing.


      reply	other threads:[~2014-06-02  8:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 17:29 [PATCH] nfs: commit layouts in fdatasync Christoph Hellwig
2014-05-05  6:56 ` Christoph Hellwig
2014-05-27 16:00   ` Christoph Hellwig
2014-05-28 23:00     ` Trond Myklebust
2014-06-02  8:19       ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140602081940.GA32300@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).