From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Wise <swise@opengridcomputing.com>
Cc: "'Devesh Sharma'" <Devesh.Sharma@Emulex.Com>,
linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org,
tom@opengridcomputing.com
Subject: Re: [PATCH V3] svcrdma: refactor marshalling logic
Date: Mon, 2 Jun 2014 12:51:52 -0400 [thread overview]
Message-ID: <20140602165151.GA20031@fieldses.org> (raw)
In-Reply-To: <004101cf7e82$68b58ad0$3a20a070$@opengridcomputing.com>
On Mon, Jun 02, 2014 at 11:47:58AM -0500, Steve Wise wrote:
>
>
> > Steve
> >
> > I have not checked the code because I am away from my laptop
> > But I assume mlx and mthca is using fmr and cxgb4 is using rdma-read-with-invalidate
> which
> > has implicit fence.
> >
> > If invalidate is issued before read is completed its a problem.
> >
>
> You're correct. And this bug appears to be in the current upstream code as well. If an
> IB_WR_LOCAL_INV wr is used, it must include IB_SEND_FENCE to fence it until the prior read
> completes.
>
> Good catch! I'll post V4 soon.
Any chance that can be handled as a separate patch rather than folded
in?
(Disclaimer: I've been following the discussion only very
superficially.)
--b.
next prev parent reply other threads:[~2014-06-02 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 16:55 [PATCH V3] svcrdma: refactor marshalling logic Steve Wise
2014-05-29 23:43 ` Chuck Lever
2014-05-30 5:29 ` Devesh Sharma
2014-05-30 13:02 ` Steve Wise
2014-05-31 3:34 ` Devesh Sharma
2014-06-02 16:47 ` Steve Wise
2014-06-02 16:51 ` J. Bruce Fields [this message]
2014-06-02 16:52 ` Steve Wise
2014-06-02 16:57 ` 'J. Bruce Fields'
2014-06-02 17:06 ` Steve Wise
2014-06-02 18:10 ` 'J. Bruce Fields'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602165151.GA20031@fieldses.org \
--to=bfields@fieldses.org \
--cc=Devesh.Sharma@Emulex.Com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=swise@opengridcomputing.com \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).