linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@primarydata.com>
Cc: trond.myklebust@primarydata.com, bhalevy@primarydata.com,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/9] nfsd: bugfixes and preliminary patches for client_mutex removal
Date: Wed, 4 Jun 2014 15:56:43 -0400	[thread overview]
Message-ID: <20140604195643.GA5603@fieldses.org> (raw)
In-Reply-To: <1401455373-18207-1-git-send-email-jlayton@primarydata.com>

On Fri, May 30, 2014 at 09:09:24AM -0400, Jeff Layton wrote:
> Hi Bruce!
> 
> This patchset contains some bugfixes and preliminary patches for
> the client_mutex removal work. I'm sending these out first as they
> either fix bugs or don't add extra locking that's only nested inside
> the client_mutex anyway.
> 
> These are based on your nfsd-next tree. Patch #3 fixes a (possibly
> minor?) bug in the fi_delegations list handling, and might be suitable
> for stable based on that. I haven't cc'ed stable on it as I can't quite
> convince myself it's a real problem, but it might be reasonable to do
> so anyway.

It looks innocent enough, so I'm adding the stable cc:.

I'm dropping patch 9 ("NFSd: protect delegation setup with the i_lock")
and applying the others.

--b.

> 
> Benny Halevy (3):
>   nfsd4: use recall_lock for delegation hashing
>   nfsd4: rename recall_lock to state_lock
>   nfsd4: hash deleg stateid only on successful nfs4_set_delegation
> 
> Jeff Layton (4):
>   nfsd: make nfsd4_encode_fattr static
>   nfsd: fix laundromat next-run-time calculation
>   nfsd: fix setting of NFS4_OO_CONFIRMED in nfsd4_open
>   nfsd: remove unneeded zeroing of fields in nfsd4_proc_compound
> 
> Trond Myklebust (2):
>   NFSd: Protect addition to the file_hashtbl
>   NFSd: protect delegation setup with the i_lock
> 
>  fs/nfsd/nfs4callback.c |  18 +++++-
>  fs/nfsd/nfs4proc.c     |   6 +-
>  fs/nfsd/nfs4state.c    | 168 ++++++++++++++++++++++++++++++-------------------
>  fs/nfsd/nfs4xdr.c      |   2 +-
>  fs/nfsd/state.h        |   1 +
>  5 files changed, 124 insertions(+), 71 deletions(-)
> 
> -- 
> 1.9.3
> 

      parent reply	other threads:[~2014-06-04 19:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 13:09 [PATCH 0/9] nfsd: bugfixes and preliminary patches for client_mutex removal Jeff Layton
2014-05-30 13:09 ` [PATCH 1/9] nfsd: make nfsd4_encode_fattr static Jeff Layton
2014-05-30 13:09 ` [PATCH 2/9] nfsd: fix laundromat next-run-time calculation Jeff Layton
2014-05-30 13:09 ` [PATCH 3/9] nfsd4: use recall_lock for delegation hashing Jeff Layton
2014-05-30 13:09 ` [PATCH 4/9] nfsd: fix setting of NFS4_OO_CONFIRMED in nfsd4_open Jeff Layton
2014-05-30 13:09 ` [PATCH 5/9] nfsd: remove unneeded zeroing of fields in nfsd4_proc_compound Jeff Layton
2014-05-30 13:09 ` [PATCH 6/9] nfsd4: rename recall_lock to state_lock Jeff Layton
2014-05-30 13:09 ` [PATCH 7/9] nfsd4: hash deleg stateid only on successful nfs4_set_delegation Jeff Layton
2014-05-30 13:09 ` [PATCH 8/9] NFSd: Protect addition to the file_hashtbl Jeff Layton
2014-06-05 16:12   ` J. Bruce Fields
2014-06-05 16:18     ` Trond Myklebust
2014-06-05 16:27       ` Jeff Layton
2014-05-30 13:09 ` [PATCH 9/9] NFSd: protect delegation setup with the i_lock Jeff Layton
2014-06-02  8:46   ` Christoph Hellwig
2014-06-02 14:17     ` Jeff Layton
2014-06-02 18:20       ` Christoph Hellwig
2014-06-02 18:48         ` Jeff Layton
2014-05-30 13:13 ` [PATCH 10/9] nfsd: remove initial assignment of "p" in nfsd4_encode_security_label Jeff Layton
2014-06-04 19:56 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140604195643.GA5603@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=bhalevy@primarydata.com \
    --cc=jlayton@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).