From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@primarydata.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSd: nfs4_preprocess_seqid_op should only set *stpp on success
Date: Sat, 7 Jun 2014 07:08:00 -0700 [thread overview]
Message-ID: <20140607140800.GA18140@infradead.org> (raw)
In-Reply-To: <1402080994-23737-1-git-send-email-jlayton@primarydata.com>
On Fri, Jun 06, 2014 at 02:56:34PM -0400, Jeff Layton wrote:
> From: Trond Myklebust <trond.myklebust@primarydata.com>
>
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
> Signed-off-by: Jeff Layton <jlayton@primarydata.com>
The new code looks correct, but shouldn't callers already take care
not to use the returned stateid only if nfs4_preprocess_seqid_op returns
0?
next prev parent reply other threads:[~2014-06-07 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 18:56 [PATCH] NFSd: nfs4_preprocess_seqid_op should only set *stpp on success Jeff Layton
2014-06-07 14:08 ` Christoph Hellwig [this message]
2014-06-07 14:23 ` Jeff Layton
2014-06-07 14:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140607140800.GA18140@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).