From: Christoph Hellwig <hch@infradead.org>
To: Weston Andros Adamson <dros@primarydata.com>
Cc: trond.myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 5/6] nfs: remove pgio_header refcount, related cleanup
Date: Sat, 7 Jun 2014 07:39:01 -0700 [thread overview]
Message-ID: <20140607143901.GE9469@infradead.org> (raw)
In-Reply-To: <1401995791-40213-6-git-send-email-dros@primarydata.com>
On Thu, Jun 05, 2014 at 03:16:30PM -0400, Weston Andros Adamson wrote:
> The refcounting on nfs_pgio_header was related to there being (possibly)
> more than one nfs_pgio_data. Now that nfs_pgio_data has been merged into
> nfs_pgio_header, there is no reason to do this ref counting. Just call
> the completion callback on nfs_pgio_release/nfs_pgio_error.
I think nfs_generic_pgio_reset isn't an all that descriptive name, why
not keep nfs_pgio_data_destroy?
next prev parent reply other threads:[~2014-06-07 14:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 19:16 [PATCH v2 0/6] more pgio cleanup Weston Andros Adamson
2014-06-05 19:16 ` [PATCH v2 1/6] nfs: move nfs_pgio_data and remove nfs_rw_header Weston Andros Adamson
2014-06-07 14:32 ` Christoph Hellwig
2014-06-05 19:16 ` [PATCH v2 2/6] nfs: rename members of nfs_pgio_data Weston Andros Adamson
2014-06-07 14:33 ` Christoph Hellwig
2014-06-05 19:16 ` [PATCH v2 3/6] nfs: merge nfs_pgio_data into _header Weston Andros Adamson
2014-06-07 14:34 ` Christoph Hellwig
2014-06-09 14:38 ` Weston Andros Adamson
2014-06-05 19:16 ` [PATCH v2 4/6] nfs: remove unused writeverf code Weston Andros Adamson
2014-06-05 19:16 ` [PATCH v2 5/6] nfs: remove pgio_header refcount, related cleanup Weston Andros Adamson
2014-06-07 14:39 ` Christoph Hellwig [this message]
2014-06-09 14:40 ` Weston Andros Adamson
2014-06-05 19:16 ` [PATCH v2 6/6] pnfs: clean up *_resend_to_mds Weston Andros Adamson
2014-06-07 14:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140607143901.GE9469@infradead.org \
--to=hch@infradead.org \
--cc=dros@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).