From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@primarydata.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: [PATCH v3 008/114] nfsd: clean up nfsd4_close_open_stateid
Date: Mon, 30 Jun 2014 11:01:27 -0700 [thread overview]
Message-ID: <20140630180127.GA20028@infradead.org> (raw)
In-Reply-To: <1404143423-24381-9-git-send-email-jlayton@primarydata.com>
On Mon, Jun 30, 2014 at 11:48:37AM -0400, Jeff Layton wrote:
> From: Trond Myklebust <trond.myklebust@primarydata.com>
>
> Minor cleanup that should introduce no behavioral changes.
>
> Currently this function just unhashes the stateid and leaves the caller
> to do the work of the CLOSE processing.
>
> Change nfsd4_close_open_stateid so that it handles doing all of the work
> of closing a stateid. Move the handling of the unhashed stateid into it
> instead of doing that work in nfsd4_close. This will help isolate some
> coming changes to stateid handling from nfsd4_close.
>
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2014-06-30 18:01 UTC|newest]
Thread overview: 151+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 15:48 [PATCH v3 000/114] nfsd: eliminate the client_mutex Jeff Layton
2014-06-30 15:48 ` [PATCH v3 001/114] nfsd: fix file access refcount leak when nfsd4_truncate fails Jeff Layton
2014-06-30 15:48 ` [PATCH v3 002/114] nfsd: Protect addition to the file_hashtbl Jeff Layton
2014-06-30 20:28 ` J. Bruce Fields
2014-06-30 20:32 ` Jeff Layton
2014-06-30 15:48 ` [PATCH v3 003/114] nfsd: wait to initialize work struct just prior to using it Jeff Layton
2014-07-08 21:11 ` J. Bruce Fields
2014-07-08 23:32 ` Jeff Layton
2014-07-09 8:21 ` Christoph Hellwig
2014-07-09 19:41 ` J. Bruce Fields
2014-07-09 20:37 ` Jeff Layton
2014-07-09 20:51 ` J. Bruce Fields
2014-07-10 7:40 ` Christoph Hellwig
2014-07-10 10:53 ` Christoph Hellwig
2014-07-10 13:23 ` Jeff Layton
2014-06-30 15:48 ` [PATCH v3 004/114] nfsd: Avoid taking state_lock while holding inode lock in nfsd_break_one_deleg Jeff Layton
2014-07-02 21:14 ` J. Bruce Fields
2014-07-03 11:20 ` Jeff Layton
2014-07-03 14:40 ` J. Bruce Fields
2014-06-30 15:48 ` [PATCH v3 005/114] nfsd: nfs4_preprocess_seqid_op should only set *stpp on success Jeff Layton
2014-06-30 15:48 ` [PATCH v3 006/114] nfsd: Cleanup nfs4svc_encode_compoundres Jeff Layton
2014-06-30 15:48 ` [PATCH v3 007/114] nfsd: declare v4.1+ openowners confirmed on creation Jeff Layton
2014-06-30 15:48 ` [PATCH v3 008/114] nfsd: clean up nfsd4_close_open_stateid Jeff Layton
2014-06-30 18:01 ` Christoph Hellwig [this message]
2014-06-30 15:48 ` [PATCH v3 009/114] nfsd: lock owners are not per open stateid Jeff Layton
2014-06-30 15:48 ` [PATCH v3 010/114] nfsd: Allow lockowners to hold several stateids Jeff Layton
2014-06-30 15:48 ` [PATCH v3 011/114] nfsd: NFSv4 lock-owners are not associated to a specific file Jeff Layton
2014-06-30 15:48 ` [PATCH v3 012/114] nfsd: clean up nfsd4_release_lockowner Jeff Layton
2014-06-30 18:02 ` Christoph Hellwig
2014-06-30 15:48 ` [PATCH v3 013/114] nfsd: Don't get a session reference without a client reference Jeff Layton
2014-06-30 15:48 ` [PATCH v3 014/114] nfsd: Cleanup - Let nfsd4_lookup_stateid() take a cstate argument Jeff Layton
2014-06-30 15:48 ` [PATCH v3 015/114] nfsd: Allow struct nfsd4_compound_state to cache the nfs4_client Jeff Layton
2014-06-30 18:03 ` Christoph Hellwig
2014-07-03 15:18 ` J. Bruce Fields
2014-07-03 15:20 ` Jeff Layton
2014-07-03 15:32 ` J. Bruce Fields
2014-07-03 15:37 ` Jeff Layton
2014-07-03 16:11 ` Christoph Hellwig
2014-07-03 16:28 ` Trond Myklebust
2014-07-03 19:07 ` Jeff Layton
2014-07-03 20:32 ` J. Bruce Fields
2014-07-03 21:35 ` J. Bruce Fields
2014-07-03 21:50 ` Jeff Layton
2014-07-03 22:31 ` Jeff Layton
2014-07-04 12:14 ` Jeff Layton
2014-07-07 18:23 ` J. Bruce Fields
2014-06-30 15:48 ` [PATCH v3 016/114] nfsd: Convert nfsd4_process_open1() to work with lookup_clientid() Jeff Layton
2014-06-30 15:48 ` [PATCH v3 017/114] nfsd: Always use lookup_clientid() in nfsd4_process_open1 Jeff Layton
2014-06-30 15:48 ` [PATCH v3 018/114] nfsd: Convert nfs4_check_open_reclaim() to work with lookup_clientid() Jeff Layton
2014-06-30 15:48 ` [PATCH v3 019/114] nfsd: Move the delegation reference counter into the struct nfs4_stid Jeff Layton
2014-06-30 15:48 ` [PATCH v3 020/114] nfsd4: use cl_lock to synchronize all stateid idr calls Jeff Layton
2014-06-30 15:48 ` [PATCH v3 021/114] nfsd: Add fine grained protection for the nfs4_file->fi_stateids list Jeff Layton
2014-06-30 15:48 ` [PATCH v3 022/114] nfsd: Add a mutex to protect the NFSv4.0 open owner replay cache Jeff Layton
2014-06-30 15:48 ` [PATCH v3 023/114] nfsd: Add locking to the nfs4_file->fi_fds[] array Jeff Layton
2014-06-30 15:48 ` [PATCH v3 024/114] nfsd: clean up helper __release_lock_stateid Jeff Layton
2014-06-30 15:48 ` [PATCH v3 025/114] nfsd: refactor nfs4_file_get_access and nfs4_file_put_access Jeff Layton
2014-06-30 15:48 ` [PATCH v3 026/114] nfsd: remove nfs4_file_put_fd Jeff Layton
2014-06-30 15:48 ` [PATCH v3 027/114] nfsd: shrink st_access_bmap and st_deny_bmap Jeff Layton
2014-07-01 10:51 ` Jeff Layton
2014-06-30 15:48 ` [PATCH v3 028/114] nfsd: set stateid access and deny bits in nfs4_get_vfs_file Jeff Layton
2014-06-30 15:48 ` [PATCH v3 029/114] nfsd: clean up reset_union_bmap_deny Jeff Layton
2014-06-30 15:48 ` [PATCH v3 030/114] nfsd: make deny mode enforcement more efficient and close races in it Jeff Layton
2014-06-30 15:49 ` [PATCH v3 031/114] nfsd: cleanup nfs4_check_open Jeff Layton
2014-06-30 15:49 ` [PATCH v3 032/114] locks: add file_has_lease to prevent delegation break races Jeff Layton
2014-06-30 15:49 ` [PATCH v3 033/114] nfsd: Protect the nfs4_file delegation fields using the fi_lock Jeff Layton
2014-06-30 15:49 ` [PATCH v3 034/114] nfsd: Simplify stateid management Jeff Layton
2014-06-30 15:49 ` [PATCH v3 035/114] nfsd: Fix delegation revocation Jeff Layton
2014-06-30 15:49 ` [PATCH v3 036/114] nfsd: Add reference counting to the lock and open stateids Jeff Layton
2014-06-30 15:49 ` [PATCH v3 037/114] nfsd: Add a struct nfs4_file field to struct nfs4_stid Jeff Layton
2014-06-30 15:49 ` [PATCH v3 038/114] nfsd: Replace nfs4_ol_stateid->st_file with the st_stid.sc_file Jeff Layton
2014-06-30 15:49 ` [PATCH v3 039/114] nfsd: Ensure stateids remain unique until they are freed Jeff Layton
2014-06-30 15:49 ` [PATCH v3 040/114] nfsd: Ensure atomicity of stateid destruction and idr tree removal Jeff Layton
2014-06-30 15:49 ` [PATCH v3 041/114] nfsd: Cleanup the freeing of stateids Jeff Layton
2014-06-30 15:49 ` [PATCH v3 042/114] nfsd: do filp_close in sc_free callback for lock stateids Jeff Layton
2014-06-30 15:49 ` [PATCH v3 043/114] nfsd: Add locking to protect the state owner lists Jeff Layton
2014-06-30 15:49 ` [PATCH v3 044/114] nfsd: clean up races in lock stateid searching and creation Jeff Layton
2014-06-30 15:49 ` [PATCH v3 045/114] nfsd: Convert delegation counter to an atomic_long_t type Jeff Layton
2014-06-30 15:49 ` [PATCH v3 046/114] nfsd: Slight cleanup of find_stateid() Jeff Layton
2014-06-30 15:49 ` [PATCH v3 047/114] nfsd: ensure atomicity in nfsd4_free_stateid and nfsd4_validate_stateid Jeff Layton
2014-06-30 15:49 ` [PATCH v3 048/114] nfsd: Add reference counting to lock stateids Jeff Layton
2014-06-30 15:49 ` [PATCH v3 049/114] nfsd: nfsd4_locku() must reference the lock stateid Jeff Layton
2014-06-30 15:49 ` [PATCH v3 050/114] nfsd: Ensure that nfs4_open_delegation() references the delegation stateid Jeff Layton
2014-06-30 15:49 ` [PATCH v3 051/114] nfsd: nfsd4_process_open2() must reference " Jeff Layton
2014-06-30 15:49 ` [PATCH v3 052/114] nfsd: nfsd4_process_open2() must reference the open stateid Jeff Layton
2014-06-30 15:49 ` [PATCH v3 053/114] nfsd: Prepare nfsd4_close() for open stateid referencing Jeff Layton
2014-06-30 15:49 ` [PATCH v3 054/114] nfsd: nfsd4_open_confirm() must reference the open stateid Jeff Layton
2014-06-30 15:49 ` [PATCH v3 055/114] nfsd: Add reference counting to nfs4_preprocess_confirmed_seqid_op Jeff Layton
2014-06-30 15:49 ` [PATCH v3 056/114] nfsd: Migrate the stateid reference into nfs4_preprocess_seqid_op Jeff Layton
2014-06-30 15:49 ` [PATCH v3 057/114] nfsd: Migrate the stateid reference into nfs4_lookup_stateid() Jeff Layton
2014-06-30 15:49 ` [PATCH v3 058/114] nfsd: Migrate the stateid reference into nfs4_find_stateid_by_type() Jeff Layton
2014-06-30 15:49 ` [PATCH v3 059/114] nfsd: Add reference counting to state owners Jeff Layton
2014-06-30 15:49 ` [PATCH v3 060/114] nfsd: Keep a reference to the open stateid for the NFSv4.0 replay cache Jeff Layton
2014-06-30 15:49 ` [PATCH v3 061/114] nfsd: clean up lockowner refcounting when finding them Jeff Layton
2014-06-30 15:49 ` [PATCH v3 062/114] nfsd: add an operation for unhashing a stateowner Jeff Layton
2014-06-30 15:49 ` [PATCH v3 063/114] nfsd: Make lock stateid take a reference to the lockowner Jeff Layton
2014-06-30 15:49 ` [PATCH v3 064/114] nfsd: clean up refcounting for lockowners Jeff Layton
2014-06-30 15:49 ` [PATCH v3 065/114] nfsd: make openstateids hold references to their openowners Jeff Layton
2014-06-30 15:49 ` [PATCH v3 066/114] nfsd: don't allow CLOSE to proceed until refcount on stateid drops Jeff Layton
2014-06-30 15:49 ` [PATCH v3 067/114] nfsd: Protect adding/removing open state owners using client_lock Jeff Layton
2014-06-30 15:49 ` [PATCH v3 068/114] nfsd: Protect adding/removing lock " Jeff Layton
2014-06-30 15:49 ` [PATCH v3 069/114] nfsd: Move the open owner hash table into struct nfs4_client Jeff Layton
2014-06-30 15:49 ` [PATCH v3 070/114] nfsd: clean up and reorganize release_lockowner Jeff Layton
2014-06-30 15:49 ` [PATCH v3 071/114] lockdep: add lockdep_assert_not_held Jeff Layton
2014-07-01 10:03 ` Peter Zijlstra
2014-07-01 10:11 ` Peter Zijlstra
2014-07-01 10:41 ` Jeff Layton
2014-07-01 11:07 ` Peter Zijlstra
2014-07-01 11:10 ` Jeff Layton
2014-06-30 15:49 ` [PATCH v3 072/114] nfsd: add locking to stateowner release Jeff Layton
2014-06-30 15:49 ` [PATCH v3 073/114] nfsd: optimize destroy_lockowner cl_lock thrashing Jeff Layton
2014-06-30 15:49 ` [PATCH v3 074/114] nfsd: close potential race in nfsd4_free_stateid Jeff Layton
2014-06-30 15:49 ` [PATCH v3 075/114] nfsd: reduce cl_lock thrashing in release_openowner Jeff Layton
2014-06-30 15:49 ` [PATCH v3 076/114] nfsd: don't thrash the cl_lock while freeing an open stateid Jeff Layton
2014-06-30 15:49 ` [PATCH v3 077/114] nfsd: Ensure struct nfs4_client is unhashed before we try to destroy it Jeff Layton
2014-06-30 15:49 ` [PATCH v3 078/114] nfsd: Ensure that the laundromat unhashes the client before releasing locks Jeff Layton
2014-06-30 15:49 ` [PATCH v3 079/114] nfsd: Don't require client_lock in free_client Jeff Layton
2014-06-30 15:49 ` [PATCH v3 080/114] nfsd: Move create_client() call outside the lock Jeff Layton
2014-06-30 15:49 ` [PATCH v3 081/114] nfsd: Protect unconfirmed client creation using client_lock Jeff Layton
2014-06-30 15:49 ` [PATCH v3 082/114] nfsd: Protect session creation and client confirm " Jeff Layton
2014-06-30 15:49 ` [PATCH v3 083/114] nfsd: Protect nfsd4_destroy_clientid " Jeff Layton
2014-06-30 15:49 ` [PATCH v3 084/114] nfsd: Ensure lookup_clientid() takes client_lock Jeff Layton
2014-06-30 15:49 ` [PATCH v3 085/114] nfsd: Add lockdep assertions to document the nfs4_client/session locking Jeff Layton
2014-06-30 15:49 ` [PATCH v3 086/114] nfsd: protect the close_lru list and oo_last_closed_stid with client_lock Jeff Layton
2014-06-30 15:49 ` [PATCH v3 087/114] nfsd: ensure that clp->cl_revoked list is protected by clp->cl_lock Jeff Layton
2014-06-30 15:49 ` [PATCH v3 088/114] nfsd: move unhash_client_locked call into mark_client_expired_locked Jeff Layton
2014-06-30 15:49 ` [PATCH v3 089/114] nfsd: don't destroy client if mark_client_expired_locked fails Jeff Layton
2014-06-30 15:49 ` [PATCH v3 090/114] nfsd: don't destroy clients that are busy Jeff Layton
2014-06-30 15:50 ` [PATCH v3 091/114] nfsd: protect clid and verifier generation with client_lock Jeff Layton
2014-06-30 15:50 ` [PATCH v3 092/114] nfsd: abstract out the get and set routines into the fault injection ops Jeff Layton
2014-06-30 15:50 ` [PATCH v3 093/114] nfsd: add a forget_clients "get" routine with proper locking Jeff Layton
2014-06-30 15:50 ` [PATCH v3 094/114] nfsd: add a forget_client set_clnt routine Jeff Layton
2014-06-30 15:50 ` [PATCH v3 095/114] nfsd: add nfsd_inject_forget_clients Jeff Layton
2014-06-30 15:50 ` [PATCH v3 096/114] nfsd: add a list_head arg to nfsd_foreach_client_lock Jeff Layton
2014-06-30 15:50 ` [PATCH v3 097/114] nfsd: add more granular locking to forget_locks fault injector Jeff Layton
2014-06-30 15:50 ` [PATCH v3 098/114] nfsd: add more granular locking to forget_openowners " Jeff Layton
2014-06-30 15:54 ` [PATCH v3 099/114] nfsd: add more granular locking to *_delegations fault injectors Jeff Layton
2014-06-30 15:54 ` [PATCH v3 100/114] nfsd: remove old fault injection infrastructure Jeff Layton
2014-06-30 15:54 ` [PATCH v3 101/114] nfsd: Remove nfs4_lock_state(): nfs4_preprocess_stateid_op() Jeff Layton
2014-06-30 15:54 ` [PATCH v3 102/114] nfsd: Remove nfs4_lock_state(): nfsd4_test_stateid/nfsd4_free_stateid Jeff Layton
2014-06-30 15:54 ` [PATCH v3 103/114] nfsd: Remove nfs4_lock_state(): nfsd4_release_lockowner Jeff Layton
2014-06-30 15:54 ` [PATCH v3 104/114] nfsd: Remove nfs4_lock_state(): nfsd4_lock/locku/lockt() Jeff Layton
2014-06-30 15:54 ` [PATCH v3 105/114] nfsd: Remove nfs4_lock_state(): nfsd4_open_downgrade + nfsd4_close Jeff Layton
2014-06-30 15:54 ` [PATCH v3 106/114] nfsd: Remove nfs4_lock_state(): nfsd4_delegreturn() Jeff Layton
2014-06-30 15:54 ` [PATCH v3 107/114] nfsd: Remove nfs4_lock_state(): nfsd4_open and nfsd4_open_confirm Jeff Layton
2014-06-30 15:54 ` [PATCH v3 108/114] nfsd: Remove nfs4_lock_state(): exchange_id, create/destroy_session() Jeff Layton
2014-06-30 15:54 ` [PATCH v3 109/114] nfsd: Remove nfs4_lock_state(): setclientid, setclientid_confirm, renew Jeff Layton
2014-06-30 15:54 ` [PATCH v3 110/114] nfsd: Remove nfs4_lock_state(): reclaim_complete() Jeff Layton
2014-06-30 15:54 ` [PATCH v3 111/114] nfsd: remove nfs4_lock_state: nfs4_laundromat Jeff Layton
2014-06-30 15:54 ` [PATCH v3 112/114] nfsd: remove nfs4_lock_state: nfs4_state_shutdown_net Jeff Layton
2014-06-30 15:55 ` [PATCH v3 113/114] nfsd: remove the client_mutex and the nfs4_lock/unlock_state wrappers Jeff Layton
2014-06-30 15:55 ` [PATCH v3 114/114] nfsd: add some comments to the nfsd4 object definitions Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630180127.GA20028@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox