From: NeilBrown <neilb@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Chuck Lever <chuck.lever@oracle.com>,
NFS <linux-nfs@vger.kernel.org>
Subject: Re: Is there a good reason that nfs4_state_manager should use a work_queue?
Date: Tue, 8 Jul 2014 16:57:27 +1000 [thread overview]
Message-ID: <20140708165727.7095e209@notabene.brown> (raw)
In-Reply-To: <20140708064641.GA16497@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Mon, 7 Jul 2014 23:46:41 -0700 Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Jul 08, 2014 at 03:21:00PM +1000, NeilBrown wrote:
> > 2/ would it be reasonable to have a single work queue for all nfs clients?
> > In the worst case this could serialise reclaim across all clients so we
> > wouldn't want any reclaim attempt to block indefinitely. Is that likely
> > to be a big problem do you think?
>
> A workqueue isn't serialized, it has a max_active paramater to control
> the concurrency of execution.
True, but if memory is tight it may not be able to create new threads.
WQ_MEM_RECLAIM guarantees there will be at least one, but worst-case
that might be all that we have.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2014-07-08 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 5:21 Is there a good reason that nfs4_state_manager should use a work_queue? NeilBrown
2014-07-08 6:46 ` Christoph Hellwig
2014-07-08 6:57 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708165727.7095e209@notabene.brown \
--to=neilb@suse.de \
--cc=chuck.lever@oracle.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox