From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: swise@ogc.net, Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3
Date: Thu, 10 Jul 2014 14:49:48 -0400 [thread overview]
Message-ID: <20140710184948.GC26561@fieldses.org> (raw)
In-Reply-To: <3BA364F8-E5ED-45A1-8662-E5F91AA7AF0A@oracle.com>
On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote:
>
> On Jul 10, 2014, at 2:19 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
>
> > On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote:
> >> The server should comply with RFC 5667,
> >
> > Where's the relevant language? (I took a quick look but didn't see it.)
>
> Sorry, I listed the wrong RFC when I wrote the description of bug 246.
> It’s actually RFC 5666, section 3.7.
Thanks.
> > So I think you just want to drop the round-up of len, not the whole
> > check.
>
> I’ll try that, thanks!
Actually, I'd really rather this get fixed up in the rpc layer. The
padding is really required for correct xdr. The fact that RDMA doesn't
require those zeroes to be literally transmitted across the network
sounds like a transport-level detail that should be hidden from the xdr
code.
--b.
next prev parent reply other threads:[~2014-07-10 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 17:44 [PATCH 0/2] NFS/RDMA server patches for 3.17 Chuck Lever
2014-07-10 17:44 ` [PATCH 1/2] svcrdma: Increase credit limit to 32 Chuck Lever
2014-07-10 17:44 ` [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3 Chuck Lever
2014-07-10 18:19 ` J. Bruce Fields
2014-07-10 18:24 ` Chuck Lever
2014-07-10 18:49 ` J. Bruce Fields [this message]
2014-07-10 19:07 ` Chuck Lever
2014-07-10 19:43 ` J. Bruce Fields
2014-07-10 20:43 ` Chuck Lever
2014-07-11 18:49 ` J. Bruce Fields
2014-07-10 19:00 ` [PATCH 0/2] NFS/RDMA server patches for 3.17 Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710184948.GC26561@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=swise@ogc.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).