From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Steve Wise <swise@opengridcomputing.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3
Date: Fri, 11 Jul 2014 14:49:30 -0400 [thread overview]
Message-ID: <20140711184929.GC9775@fieldses.org> (raw)
In-Reply-To: <F8AD3320-C653-4713-965F-FE52FF0D49CA@oracle.com>
On Thu, Jul 10, 2014 at 04:43:54PM -0400, Chuck Lever wrote:
> I think the sanity check you pointed out is strictly satisfied by
> testing against the unaligned number of bytes. Is there a strong
> reason to do the extra math for that check during each WRITE?
I can't think of any good reason why the check should be against the
rounded-up length.
So my worry was just a more general "uh-oh, a non-multiple-of-4-length
is pretty weird, future me may not remember that's a possibility."
--b.
next prev parent reply other threads:[~2014-07-11 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 17:44 [PATCH 0/2] NFS/RDMA server patches for 3.17 Chuck Lever
2014-07-10 17:44 ` [PATCH 1/2] svcrdma: Increase credit limit to 32 Chuck Lever
2014-07-10 17:44 ` [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3 Chuck Lever
2014-07-10 18:19 ` J. Bruce Fields
2014-07-10 18:24 ` Chuck Lever
2014-07-10 18:49 ` J. Bruce Fields
2014-07-10 19:07 ` Chuck Lever
2014-07-10 19:43 ` J. Bruce Fields
2014-07-10 20:43 ` Chuck Lever
2014-07-11 18:49 ` J. Bruce Fields [this message]
2014-07-10 19:00 ` [PATCH 0/2] NFS/RDMA server patches for 3.17 Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711184929.GC9775@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).