From: "J. Bruce Fields" <bfields@fieldses.org>
To: linux-nfs@vger.kernel.org
Subject: [PATCH] nfsd4: handle failure to find backchannel
Date: Fri, 11 Jul 2014 17:16:09 -0400 [thread overview]
Message-ID: <20140711211609.GA13656@fieldses.org> (raw)
The local variable "ses" will be left NULL here in the case we fail to
find a connection. Spotted by a coverity scan.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 2c73cae9899d..fe22cd5c42d3 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1001,14 +1001,18 @@ static void nfsd4_process_cb_update(struct nfsd4_callback *cb)
}
spin_unlock(&clp->cl_lock);
+ if (!c)
+ goto out_no_connection;
err = setup_callback_client(clp, &conn, ses);
- if (err) {
- nfsd4_mark_cb_down(clp, err);
- return;
- }
+ if (err)
+ goto out_no_connection;
/* Yay, the callback channel's back! Restart any callbacks: */
list_for_each_entry(cb, &clp->cl_callbacks, cb_per_client)
run_nfsd4_cb(cb);
+ return;
+out_no_connection:
+ nfsd4_mark_cb_down(clp, err);
+ return;
}
static void nfsd4_do_callback_rpc(struct work_struct *w)
next reply other threads:[~2014-07-11 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 21:16 J. Bruce Fields [this message]
2014-07-12 14:02 ` [PATCH] nfsd4: handle failure to find backchannel Kinglong Mee
2014-07-16 22:05 ` J. Bruce Fields
2014-07-17 13:24 ` Kinglong Mee
2014-07-17 15:13 ` J. Bruce Fields
2014-07-18 0:01 ` Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711211609.GA13656@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox