linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/7] Add RCU-walk support to NFS.
Date: Mon, 14 Jul 2014 12:25:31 +1000	[thread overview]
Message-ID: <20140714122531.13a69cc8@notabene.brown> (raw)
In-Reply-To: <CAHQdGtS2XW=GeyxHddKKAb9a2tucO9kzxatPJ78qpMiDiOagiQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]

On Sun, 13 Jul 2014 22:00:12 -0400 Trond Myklebust
<trond.myklebust@primarydata.com> wrote:

> On Sun, Jul 13, 2014 at 9:28 PM, NeilBrown <neilb@suse.de> wrote:
> > NFS current abort and attempt at filename lookup in RCU mode.
> > This can have serious performance impact on a highly parallel load.
> >
> > The "Makefile" below generates just such a load.  On a 40-core
> > machine "make -j 40" is about 6 times as fast at "make -j 5"
> > when a local filesystem is used (e.g. XFS), but as much as half
> > as fast when NFS is used.
> > With this patch set, "make -j 40" is about 3 times as fast as
> > "make -j 5" on NFS, and "perf" data doesn't show spinlocks to be a big
> > problem any more.
> >
> > This is a re-submission with a few small improvements of a patch set
> > posted in March.  Since then I have recieved confirmation that it
> > definitely fixes the problem, when combined with a patch set which
> > enhances autofs4 in a similar way.  So it has had quite a bit of
> > testing.
> 
> Hi Neil,
> 
> What kind of tests have you personally (or SuSE if relevant) performed?
> Have you run this under NFSometer in order to check for regressions,
> and if so on what workloads?
> 
> The above are not requirements in order to get the patches into
> mainline, I'm just curious.

I hadn't come across NFSometer before, looks useful!

The only testing is that Makefile, and that was done mostly by the customer.

Further, that testing was a version of the patchset for Linux 3.0.
This particular patchset I've only tested lightly on my little 2-core test
machine.
I'm certainly happy to try beating on it a bit hard, and can see if I can get
access to an 80-core machine that I had a brief play with a while back and do
some more testing there.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2014-07-14  2:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14  1:28 [PATCH 0/7] Add RCU-walk support to NFS NeilBrown
2014-07-14  1:28 ` [PATCH 1/7] NFS: nfs4_lookup_revalidate: only evaluate parent if it will be used NeilBrown
2014-07-15 16:56   ` Christoph Hellwig
2014-07-14  1:28 ` [PATCH 2/7] NFS: prepare for RCU-walk support but pushing tests later in code NeilBrown
2014-07-14  1:28 ` [PATCH 7/7] NFS: allow lockless access to access_cache NeilBrown
2014-07-14  1:28 ` [PATCH 4/7] NFS: support RCU_WALK in nfs_permission() NeilBrown
2014-07-14  1:28 ` [PATCH 3/7] sunrpc/auth: allow lockless (rcu) lookup of credential cache NeilBrown
2014-07-14  1:28 ` [PATCH 5/7] NFS: teach nfs_neg_need_reval to understand LOOKUP_RCU NeilBrown
2014-07-14  1:28 ` [PATCH 6/7] NFS: teach nfs_lookup_verify_inode to handle LOOKUP_RCU NeilBrown
2014-07-14  2:00 ` [PATCH 0/7] Add RCU-walk support to NFS Trond Myklebust
2014-07-14  2:25   ` NeilBrown [this message]
2014-07-14  2:39     ` Trond Myklebust
2014-07-23  7:14       ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714122531.13a69cc8@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).