Re: [PATCH] nfsd: silence sparse warning about accessing credentials

[Jeff Layton <jeff.layton@primarydata.com>]

On Tue, 15 Jul 2014 09:45:27 -0700
Christoph Hellwig <hch@infradead.org> wrote:

> On Tue, Jul 15, 2014 at 06:28:54AM -0400, Jeff Layton wrote:
> > sparse says:
> > 
> >     fs/nfsd/auth.c:31:38: warning: incorrect type in argument 1 (different address spaces)
> >     fs/nfsd/auth.c:31:38:    expected struct cred const *cred
> >     fs/nfsd/auth.c:31:38:    got struct cred const [noderef] <asn:4>*real_cred
> > 
> > Add a new accessor for the ->real_cred and use that to fetch the
> > pointer. Accessing current->real_cred directly is actually quite safe
> > since we know that they can't go away so this is mostly a cosmetic fixup
> > to silence sparse.
> 
> This looks reasonable, but I'd suggest Ccing linux-kernel for changes to
> global headers.
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Ok, good point. I'll resend and cc there.

FWIW, I also sent a patch to linux-sparse today which will silence the
last sparse warning when building nfsd.ko.

Thanks,
-- 
Jeff Layton <jlayton@primarydata.com>