Re: [PATCH/RFC] NFS: state manager thread must start running.

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

On Tue, 15 Jul 2014 00:49:42 -0700 Christoph Hellwig <hch@infradead.org>
wrote:

> On Tue, Jul 15, 2014 at 04:39:42PM +1000, NeilBrown wrote:
> > I suggested in an earlier email that it might be possible to use a
> > work-queue for this.  I concluded that it wasn't a good idea.
> > If a server was down, the manager cold block indefinitely.
> > If memory was tight and only one workqueue thread was active,
> > this would block other NFS mounts.
> 
> So allocate one workqueue per mount?

Could do that (or per-client) but it doesn't really buy us anything does it?
The state manager assumes it is single threads, so it would need to be
a single-threaded workqueue with always at least one thread running.
That is much the same as a kthread.

And then there is that fact that the current code explicitly enabled SIGKILL
and maybe that is important.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]