Linux NFS development
 help / color / mirror / Atom feed
From: Jeff Layton <jeff.layton@primarydata.com>
To: bfields@fieldses.org
Cc: hch@infradead.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 0/8] nfsd: more delegation fixes to prepare for client_mutex removal
Date: Wed, 16 Jul 2014 10:33:43 -0400	[thread overview]
Message-ID: <20140716103343.76205f59@tlielax.poochiereds.net> (raw)
In-Reply-To: <1405521125-2303-1-git-send-email-jlayton@primarydata.com>

On Wed, 16 Jul 2014 10:31:55 -0400
Jeff Layton <jlayton@primarydata.com> wrote:

> Here's a respin of the delegation fixes that I sent yesterday. The main
> change is to move the remove_stid calls into the caller in the second
> patch instead of keeping it in nfs4_free_stid, per Christoph's
> suggestion.
> 
> Unfortunately, that causes a pile of merge conflicts in the later
> patches, so I need to resend the whole set.
> 
> I also include the patch that converts the num_delegations counter to an
> atomic_long_t, as I missed that in the earlier series.
> 
> There is one more patch that fixes up handling of the cl_revoked list
> that comes later, but it can't easily be moved here as it depends on
> some locking changes that come later.
> 
> Jeff Layton (6):
>   nfsd: eliminate nfsd4_init_callback
>   nfsd: Avoid taking state_lock while holding inode lock in
>     nfsd_break_one_deleg
>   nfsd: nfs4_alloc_init_lease should take a nfs4_file arg
>   locks: add file_has_lease to prevent delegation break races
>   nfsd: Protect the nfs4_file delegation fields using the fi_lock
>   nfsd: Fix delegation revocation
> 
> Trond Myklebust (4):
>   nfsd: Ensure stateids remain unique until they are freed
>   nfsd: Move the delegation reference counter into the struct nfs4_stid
>   nfsd: Simplify stateid management
>   nfsd: Convert delegation counter to an atomic_long_t type
> 
>  fs/locks.c             |  26 +++++++
>  fs/nfsd/nfs4callback.c |  23 ++++--
>  fs/nfsd/nfs4state.c    | 197 +++++++++++++++++++++++++++++++------------------
>  fs/nfsd/state.h        |   7 +-
>  include/linux/fs.h     |   6 ++
>  5 files changed, 179 insertions(+), 80 deletions(-)
> 

Sorry...obviously the subject here should have read "0/10" and not "0/8".

-- 
Jeff Layton <jlayton@primarydata.com>

      parent reply	other threads:[~2014-07-16 14:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 14:31 [PATCH v2 0/8] nfsd: more delegation fixes to prepare for client_mutex removal Jeff Layton
2014-07-16 14:31 ` [PATCH v2 01/10] nfsd: eliminate nfsd4_init_callback Jeff Layton
2014-07-16 14:31 ` [PATCH v2 02/10] nfsd: Avoid taking state_lock while holding inode lock in nfsd_break_one_deleg Jeff Layton
2014-07-17  1:34   ` J. Bruce Fields
2014-07-17 10:57     ` Jeff Layton
2014-07-16 14:31 ` [PATCH v2 03/10] nfsd: nfs4_alloc_init_lease should take a nfs4_file arg Jeff Layton
2014-07-16 14:31 ` [PATCH v2 04/10] nfsd: Ensure stateids remain unique until they are freed Jeff Layton
2014-07-17 18:44   ` J. Bruce Fields
2014-07-17 18:46     ` Jeff Layton
2014-07-16 14:32 ` [PATCH v2 05/10] locks: add file_has_lease to prevent delegation break races Jeff Layton
2014-07-16 14:32 ` [PATCH v2 06/10] nfsd: Protect the nfs4_file delegation fields using the fi_lock Jeff Layton
2014-07-16 18:09   ` Christoph Hellwig
2014-07-16 19:04     ` Jeff Layton
2014-07-17 14:55       ` Christoph Hellwig
2014-07-17 15:31         ` Jeff Layton
2014-07-16 14:32 ` [PATCH v2 07/10] nfsd: Move the delegation reference counter into the struct nfs4_stid Jeff Layton
2014-07-16 14:32 ` [PATCH v2 08/10] nfsd: Simplify stateid management Jeff Layton
2014-07-16 18:10   ` Christoph Hellwig
2014-07-16 14:32 ` [PATCH v2 09/10] nfsd: Fix delegation revocation Jeff Layton
2014-07-16 18:30   ` Christoph Hellwig
2014-07-16 19:16     ` Jeff Layton
2014-07-17  9:22       ` Christoph Hellwig
2014-07-16 14:32 ` [PATCH v2 10/10] nfsd: Convert delegation counter to an atomic_long_t type Jeff Layton
2014-07-16 18:11   ` Christoph Hellwig
2014-07-16 14:33 ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140716103343.76205f59@tlielax.poochiereds.net \
    --to=jeff.layton@primarydata.com \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox