Linux NFS development
 help / color / mirror / Atom feed
From: Bruce Fields <bfields@fieldses.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: xdr_get_next_encode_buffer should be declared static
Date: Wed, 16 Jul 2014 16:58:46 -0400	[thread overview]
Message-ID: <20140716205846.GE2397@fieldses.org> (raw)
In-Reply-To: <1405202462-50244-1-git-send-email-trond.myklebust@primarydata.com>

On Sat, Jul 12, 2014 at 06:01:02PM -0400, Trond Myklebust wrote:
> Quell another sparse warning.

I think jlayton sent you the same fix with his set of sunrpc sparse
fixes--could you just take that instead?

(Or I can take this if you still want, I don't really care.)

--b.

> 
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
> ---
>  net/sunrpc/xdr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index 23fb4e75e245..290af97bf6f9 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -509,7 +509,8 @@ void xdr_commit_encode(struct xdr_stream *xdr)
>  }
>  EXPORT_SYMBOL_GPL(xdr_commit_encode);
>  
> -__be32 *xdr_get_next_encode_buffer(struct xdr_stream *xdr, size_t nbytes)
> +static __be32 *xdr_get_next_encode_buffer(struct xdr_stream *xdr,
> +		size_t nbytes)
>  {
>  	static __be32 *p;
>  	int space_left;
> -- 
> 1.9.3
> 

  parent reply	other threads:[~2014-07-16 20:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12 22:01 [PATCH] SUNRPC: xdr_get_next_encode_buffer should be declared static Trond Myklebust
2014-07-15 17:01 ` Christoph Hellwig
2014-07-16 20:58 ` Bruce Fields [this message]
2014-07-16 21:40   ` Trond Myklebust
2014-07-16 21:44     ` Bruce Fields
2014-07-17 18:41       ` Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140716205846.GE2397@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox