From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kinglong Mee <kinglongmee@gmail.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: Fix bad reserving space for encoding rdattr_error
Date: Wed, 16 Jul 2014 18:06:29 -0400 [thread overview]
Message-ID: <20140716220629.GH2397@fieldses.org> (raw)
In-Reply-To: <20140714095944.GA25481@infradead.org>
On Mon, Jul 14, 2014 at 02:59:44AM -0700, Christoph Hellwig wrote:
> On Fri, Jul 11, 2014 at 04:11:29PM -0400, J. Bruce Fields wrote:
> > > On Mon, Jul 07, 2014 at 02:15:56PM -0400, J. Bruce Fields wrote:
> > > > > - p = xdr_reserve_space(xdr, 6);
> > > > > + p = xdr_reserve_space(xdr, 20);
> > >
> > > Can we please convert all these magic numbers to expressions adding up
> > > sizeofs or where that doesn't fit use #defines?
> >
> > So, this would be
> >
> > xdr_reserve_space(xdr, 5 * sizeof(be32));
> >
> > ? I guess that'd be OK.
>
> Yes, that makes a lot more sense.
Sounds reasonable to me. I'm not volunteering for now.
> I'm still hoping to make progress
> on my krpcgen one day..
OK, good luck....
--b.
next prev parent reply other threads:[~2014-07-16 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 3:34 [PATCH] nfsd: Fix bad reserving space for encoding rdattr_error Kinglong Mee
2014-07-07 18:15 ` J. Bruce Fields
2014-07-10 10:54 ` Christoph Hellwig
2014-07-11 20:11 ` J. Bruce Fields
2014-07-14 9:59 ` Christoph Hellwig
2014-07-16 22:06 ` J. Bruce Fields [this message]
2014-07-17 13:18 ` Kinglong Mee
2014-07-18 11:55 ` [PATCH] NFSD: Convert magic number to sizeof() for encode and decode Kinglong Mee
2014-08-12 20:40 ` J. Bruce Fields
2014-08-14 12:32 ` Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716220629.GH2397@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).