linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] svcrdma: Double the default credit limit
Date: Wed, 23 Jul 2014 11:00:44 -0400	[thread overview]
Message-ID: <20140723150044.GW8438@fieldses.org> (raw)
In-Reply-To: <20140722214804.3398.34829.stgit@klimt.1015granger.net>

On Tue, Jul 22, 2014 at 05:48:04PM -0400, Chuck Lever wrote:
> The RDMA credit limit controls how many concurrent RPCs are allowed
> per connection.
> 
> An NFS/RDMA client and server exchange their credit limits in the
> RPC/RDMA headers. The Linux client and the Solaris client and server
> allow 32 credits. The Linux server allows only 16, which limits its
> performance.
> 
> Set the server's default credit limit to 32, like the other well-
> known implementations, so the out-of-the-shrinkwrap performance of
> the Linux server is better.

Thanks, applying for 3.17.--b.

> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
>  include/linux/sunrpc/svc_rdma.h |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> index 5cf99a0..975da75 100644
> --- a/include/linux/sunrpc/svc_rdma.h
> +++ b/include/linux/sunrpc/svc_rdma.h
> @@ -174,8 +174,7 @@ struct svcxprt_rdma {
>   * page size of 4k, or 32k * 2 ops / 4k = 16 outstanding RDMA_READ.  */
>  #define RPCRDMA_ORD             (64/4)
>  #define RPCRDMA_SQ_DEPTH_MULT   8
> -#define RPCRDMA_MAX_THREADS     16
> -#define RPCRDMA_MAX_REQUESTS    16
> +#define RPCRDMA_MAX_REQUESTS    32
>  #define RPCRDMA_MAX_REQ_SIZE    4096
>  
>  /* svc_rdma_marshal.c */
> 

      reply	other threads:[~2014-07-23 15:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 21:48 [PATCH] svcrdma: Double the default credit limit Chuck Lever
2014-07-23 15:00 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140723150044.GW8438@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).