From: Christoph Hellwig <hch@infradead.org>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: trond.myklebust@primarydata.com, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL
Date: Sun, 27 Jul 2014 06:19:17 -0700 [thread overview]
Message-ID: <20140727131917.GA32153@infradead.org> (raw)
In-Reply-To: <1406375881-18837-1-git-send-email-andrey.krieger.utkin@gmail.com>
On Sat, Jul 26, 2014 at 02:58:01PM +0300, Andrey Utkin wrote:
> There was a check for result being not NULL. But get_acl() may return
> NULL, or ERR_PTR, or actual pointer.
> The purpose of the function where current change is done is to "list
> ACLs only when they are available", so any error condition of get_acl()
> mustn't be elevated, and returning 0 there is still valid.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81111
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Looks good, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
should probably get a cc to stable as the original patch has one
as well.
next prev parent reply other threads:[~2014-07-27 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 11:58 [PATCH] nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL Andrey Utkin
2014-07-27 13:19 ` Christoph Hellwig [this message]
2014-07-27 15:13 ` Trond Myklebust
2014-07-27 19:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140727131917.GA32153@infradead.org \
--to=hch@infradead.org \
--cc=andrey.krieger.utkin@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).