From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrey Utkin <andrey.krieger.utkin@gmail.com>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH] nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL
Date: Sun, 27 Jul 2014 12:50:41 -0700 [thread overview]
Message-ID: <20140727195041.GA11575@infradead.org> (raw)
In-Reply-To: <CAHQdGtRzDzpOuwZYWaBake-bH0z0eyMd2g-RTVwO0d2f0Zmsow@mail.gmail.com>
On Sun, Jul 27, 2014 at 11:13:50AM -0400, Trond Myklebust wrote:
> Why are we not passing the error code back to the caller here in the
> case where we have one? One of the main purposes of returning an error
> in get_acl() is to ensure that we pass -EOPNOTSUPP if the operation
> fails due to lack of server support.
Do we really want to return EOPNOTSUPP from listxattr? Seems like
simply not listing anything if the server doesn't support ACLs would
be the usual behaviour. E.g. on local filesystems we'll also just get
back an empty list of xattrs if ACLs aren't supported and not other
attribute is set.
prev parent reply other threads:[~2014-07-27 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 11:58 [PATCH] nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL Andrey Utkin
2014-07-27 13:19 ` Christoph Hellwig
2014-07-27 15:13 ` Trond Myklebust
2014-07-27 19:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140727195041.GA11575@infradead.org \
--to=hch@infradead.org \
--cc=andrey.krieger.utkin@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).