From: Chuck Lever <chuck.lever@oracle.com>
To: Anna.Schumaker@netapp.com
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v5 16/21] xprtrdma: Rename frmr_wr
Date: Tue, 29 Jul 2014 17:25:29 -0400 [thread overview]
Message-ID: <20140729212529.2812.90342.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20140729211534.2812.3128.stgit@manet.1015granger.net>
Clean up: Name frmr_wr after the opcode of the Work Request,
consistent with the send and local invalidation paths.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Steve Wise <swise@opengridcomputing.com>
Tested-by: Shirley Ma <shirley.ma@oracle.com>
Tested-by: Devesh Sharma <devesh.sharma@emulex.com>
---
net/sunrpc/xprtrdma/verbs.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 750fdf9..817d5ac 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -1684,7 +1684,7 @@ rpcrdma_register_frmr_external(struct rpcrdma_mr_seg *seg,
struct rpcrdma_mw *mw = seg1->mr_chunk.rl_mw;
struct rpcrdma_frmr *frmr = &mw->r.frmr;
struct ib_mr *mr = frmr->fr_mr;
- struct ib_send_wr frmr_wr, *bad_wr;
+ struct ib_send_wr fastreg_wr, *bad_wr;
u8 key;
int len, pageoff;
int i, rc;
@@ -1718,15 +1718,15 @@ rpcrdma_register_frmr_external(struct rpcrdma_mr_seg *seg,
frmr->fr_state = FRMR_IS_VALID;
- memset(&frmr_wr, 0, sizeof frmr_wr);
- frmr_wr.wr_id = (unsigned long)(void *)mw;
- frmr_wr.opcode = IB_WR_FAST_REG_MR;
- frmr_wr.wr.fast_reg.iova_start = seg1->mr_dma;
- frmr_wr.wr.fast_reg.page_list = frmr->fr_pgl;
- frmr_wr.wr.fast_reg.page_list_len = page_no;
- frmr_wr.wr.fast_reg.page_shift = PAGE_SHIFT;
- frmr_wr.wr.fast_reg.length = page_no << PAGE_SHIFT;
- if (frmr_wr.wr.fast_reg.length < len) {
+ memset(&fastreg_wr, 0, sizeof(fastreg_wr));
+ fastreg_wr.wr_id = (unsigned long)(void *)mw;
+ fastreg_wr.opcode = IB_WR_FAST_REG_MR;
+ fastreg_wr.wr.fast_reg.iova_start = seg1->mr_dma;
+ fastreg_wr.wr.fast_reg.page_list = frmr->fr_pgl;
+ fastreg_wr.wr.fast_reg.page_list_len = page_no;
+ fastreg_wr.wr.fast_reg.page_shift = PAGE_SHIFT;
+ fastreg_wr.wr.fast_reg.length = page_no << PAGE_SHIFT;
+ if (fastreg_wr.wr.fast_reg.length < len) {
rc = -EIO;
goto out_err;
}
@@ -1735,13 +1735,13 @@ rpcrdma_register_frmr_external(struct rpcrdma_mr_seg *seg,
key = (u8)(mr->rkey & 0x000000FF);
ib_update_fast_reg_key(mr, ++key);
- frmr_wr.wr.fast_reg.access_flags = (writing ?
+ fastreg_wr.wr.fast_reg.access_flags = (writing ?
IB_ACCESS_REMOTE_WRITE | IB_ACCESS_LOCAL_WRITE :
IB_ACCESS_REMOTE_READ);
- frmr_wr.wr.fast_reg.rkey = mr->rkey;
+ fastreg_wr.wr.fast_reg.rkey = mr->rkey;
DECR_CQCOUNT(&r_xprt->rx_ep);
- rc = ib_post_send(ia->ri_id->qp, &frmr_wr, &bad_wr);
+ rc = ib_post_send(ia->ri_id->qp, &fastreg_wr, &bad_wr);
if (rc) {
dprintk("RPC: %s: failed ib_post_send for register,"
" status %i\n", __func__, rc);
next prev parent reply other threads:[~2014-07-29 21:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 21:23 [PATCH v5 00/21] NFS/RDMA client patches for 3.17 Chuck Lever
2014-07-29 21:23 ` [PATCH v5 01/21] xprtrdma: Fix panic in rpcrdma_register_frmr_external() Chuck Lever
2014-07-29 21:23 ` [PATCH v5 02/21] xprtrdma: Protect ia->ri_id when unmapping/invalidating MRs Chuck Lever
2014-07-29 21:23 ` [PATCH v5 03/21] xprtrdma: Limit data payload size for ALLPHYSICAL Chuck Lever
2014-07-29 21:23 ` [PATCH v5 04/21] xprtrdma: Update rkeys after transport reconnect Chuck Lever
2014-07-29 21:23 ` [PATCH v5 05/21] xprtrdma: On disconnect, don't ignore pending CQEs Chuck Lever
2014-07-29 21:24 ` [PATCH v5 06/21] xprtrdma: Don't invalidate FRMRs if registration fails Chuck Lever
2014-07-29 21:24 ` [PATCH v5 07/21] xprtrdma: Unclutter struct rpcrdma_mr_seg Chuck Lever
2014-07-29 21:24 ` [PATCH v5 08/21] xprtrdma: Back off rkey when FAST_REG_MR fails Chuck Lever
2014-07-29 21:24 ` [PATCH v5 09/21] xprtrdma: Chain together all MWs in same buffer pool Chuck Lever
2014-07-29 21:24 ` [PATCH v5 10/21] xprtrdma: Properly handle exhaustion of the rb_mws list Chuck Lever
2014-07-29 21:24 ` [PATCH v5 11/21] xprtrdma: Reset FRMRs when FAST_REG_MR is flushed by a disconnect Chuck Lever
2014-07-29 21:24 ` [PATCH v5 12/21] xprtrdma: Reset FRMRs after a flushed LOCAL_INV Work Request Chuck Lever
2014-07-29 21:25 ` [PATCH v5 13/21] xprtrdma: Don't post a LOCAL_INV in rpcrdma_register_frmr_external() Chuck Lever
2014-07-29 21:25 ` [PATCH v5 14/21] xprtrdma: Disable completions for FAST_REG_MR Work Requests Chuck Lever
2014-07-29 21:25 ` [PATCH v5 15/21] xprtrdma: Disable completions for LOCAL_INV " Chuck Lever
2014-07-29 21:25 ` Chuck Lever [this message]
2014-07-29 21:25 ` [PATCH v5 17/21] xprtrdma: Allocate each struct rpcrdma_mw separately Chuck Lever
2014-07-29 21:25 ` [PATCH v5 18/21] xprtrdma: Schedule reply tasklet once per upcall Chuck Lever
2014-07-29 21:25 ` [PATCH v5 19/21] xprtrdma: Make rpcrdma_ep_disconnect() return void Chuck Lever
2014-07-29 21:26 ` [PATCH v5 20/21] xprtrdma: Remove RPCRDMA_PERSISTENT_REGISTRATION macro Chuck Lever
2014-07-29 21:26 ` [PATCH v5 21/21] xprtrdma: Handle additional connection events Chuck Lever
2014-07-31 20:44 ` [PATCH v5 00/21] NFS/RDMA client patches for 3.17 Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729212529.2812.90342.stgit@manet.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).