From: Jeff Layton <jeff.layton@primarydata.com>
To: Natanael Copa <natanael.copa@gmail.com>
Cc: linux-nfs@vger.kernel.org, Natanael Copa <ncopa@alpinelinux.org>
Subject: Re: [PATCH 11/11] exportfs: only do glibc specific hackery on glibc
Date: Wed, 30 Jul 2014 08:06:10 -0400 [thread overview]
Message-ID: <20140730080610.7655e15e@tlielax.poochiereds.net> (raw)
In-Reply-To: <1406719399-1735-12-git-send-email-ncopa@alpinelinux.org>
On Wed, 30 Jul 2014 13:23:19 +0200
Natanael Copa <natanael.copa@gmail.com> wrote:
> We should not depend on the libc do free(3) on ai_canonname as that is
> completely up to implementation and known o break things on uclibc and
> musl libc.
>
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> ---
> support/export/hostname.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/support/export/hostname.c b/support/export/hostname.c
> index d9153e1..30584b4 100644
> --- a/support/export/hostname.c
> +++ b/support/export/hostname.c
> @@ -382,6 +382,7 @@ host_numeric_addrinfo(const struct sockaddr *sap)
>
> ai = host_pton(buf);
>
> +#if !definded(__UCLIBC__) && defined(__GLIBC__)
As I mentioned on IRC, there's a typo above...
> /*
> * getaddrinfo(AI_NUMERICHOST) never fills in ai_canonname
> */
> @@ -392,7 +393,9 @@ host_numeric_addrinfo(const struct sockaddr *sap)
> ai = NULL;
> }
> }
> +#endif
>
> return ai;
> }
> +
> #endif /* !HAVE_GETNAMEINFO */
--
Jeff Layton <jlayton@primarydata.com>
next prev parent reply other threads:[~2014-07-30 12:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 11:23 [PATCH 00/11] Porting nfs-utils to musl libc Natanael Copa
2014-07-30 11:23 ` [PATCH 01/11] conffile: use standard uint*_t and unsigned char Natanael Copa
2014-07-30 11:23 ` [PATCH 02/11] Fix header include for definition of NULL Natanael Copa
2014-07-30 11:23 ` [PATCH 03/11] replace __attribute_malloc__ with the more portable __attribute__((__malloc__)) Natanael Copa
2014-07-30 11:23 ` [PATCH 04/11] exportfs: define _GNU_SOURCE for stat64 Natanael Copa
2014-07-31 1:30 ` NeilBrown
2014-07-31 11:34 ` Jeff Layton
2014-08-05 15:08 ` Steve Dickson
2014-08-06 6:50 ` Natanael Copa
2014-07-30 11:23 ` [PATCH 05/11] mountd: define _GNU_SOURCE for statfs64 and use standard dev_t Natanael Copa
2014-07-30 11:23 ` [PATCH 06/11] nfsstat: replace the legacy SA_ONESHOT with standard SA_RESETHAND Natanael Copa
2014-07-30 11:23 ` [PATCH 07/11] Allow usage of getrpcbynumber() when getrpcbynumber_r() is unavailable Natanael Copa
2014-07-30 11:23 ` [PATCH 08/11] include libgen.h for basename Natanael Copa
2014-07-30 11:23 ` [PATCH 09/11] Only work around glibc bugs on glibc Natanael Copa
2014-07-30 11:23 ` [PATCH 10/11] exportfs: fix test of NULL pointer in host_pton() Natanael Copa
2014-07-30 11:23 ` [PATCH 11/11] exportfs: only do glibc specific hackery on glibc Natanael Copa
2014-07-30 12:06 ` Jeff Layton [this message]
2014-08-07 12:15 ` Steve Dickson
2014-08-08 9:38 ` Natanael Copa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730080610.7655e15e@tlielax.poochiereds.net \
--to=jeff.layton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=natanael.copa@gmail.com \
--cc=ncopa@alpinelinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).