From: NeilBrown <neilb@suse.de>
To: Natanael Copa <natanael.copa@gmail.com>
Cc: linux-nfs@vger.kernel.org, Natanael Copa <ncopa@alpinelinux.org>
Subject: Re: [PATCH 04/11] exportfs: define _GNU_SOURCE for stat64
Date: Thu, 31 Jul 2014 11:30:22 +1000 [thread overview]
Message-ID: <20140731113022.22afdefc@notabene.brown> (raw)
In-Reply-To: <1406719399-1735-5-git-send-email-ncopa@alpinelinux.org>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
On Wed, 30 Jul 2014 13:23:12 +0200 Natanael Copa <natanael.copa@gmail.com>
wrote:
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> ---
> utils/exportfs/exportfs.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index bf07555..7ab93d1 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -12,6 +12,10 @@
> #include <config.h>
> #endif
>
> +#ifndef _GNU_SOURCE
> +#define _GNU_SOURCE
> +#endif
> +
> #include <sys/types.h>
> #include <sys/stat.h>
> #include <sys/vfs.h>
These all look really sensible!
One small suggestion: it would be really nice to see a comment in the code
explaining why _GNU_SOURCE is needed. I suspect such comments get out of
date quickly, so maybe it wouldn't end up be all that useful. But having a
comment is still, in my opinion, more useful than not.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2014-07-31 1:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 11:23 [PATCH 00/11] Porting nfs-utils to musl libc Natanael Copa
2014-07-30 11:23 ` [PATCH 01/11] conffile: use standard uint*_t and unsigned char Natanael Copa
2014-07-30 11:23 ` [PATCH 02/11] Fix header include for definition of NULL Natanael Copa
2014-07-30 11:23 ` [PATCH 03/11] replace __attribute_malloc__ with the more portable __attribute__((__malloc__)) Natanael Copa
2014-07-30 11:23 ` [PATCH 04/11] exportfs: define _GNU_SOURCE for stat64 Natanael Copa
2014-07-31 1:30 ` NeilBrown [this message]
2014-07-31 11:34 ` Jeff Layton
2014-08-05 15:08 ` Steve Dickson
2014-08-06 6:50 ` Natanael Copa
2014-07-30 11:23 ` [PATCH 05/11] mountd: define _GNU_SOURCE for statfs64 and use standard dev_t Natanael Copa
2014-07-30 11:23 ` [PATCH 06/11] nfsstat: replace the legacy SA_ONESHOT with standard SA_RESETHAND Natanael Copa
2014-07-30 11:23 ` [PATCH 07/11] Allow usage of getrpcbynumber() when getrpcbynumber_r() is unavailable Natanael Copa
2014-07-30 11:23 ` [PATCH 08/11] include libgen.h for basename Natanael Copa
2014-07-30 11:23 ` [PATCH 09/11] Only work around glibc bugs on glibc Natanael Copa
2014-07-30 11:23 ` [PATCH 10/11] exportfs: fix test of NULL pointer in host_pton() Natanael Copa
2014-07-30 11:23 ` [PATCH 11/11] exportfs: only do glibc specific hackery on glibc Natanael Copa
2014-07-30 12:06 ` Jeff Layton
2014-08-07 12:15 ` Steve Dickson
2014-08-08 9:38 ` Natanael Copa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731113022.22afdefc@notabene.brown \
--to=neilb@suse.de \
--cc=linux-nfs@vger.kernel.org \
--cc=natanael.copa@gmail.com \
--cc=ncopa@alpinelinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).