linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
	NFS <linux-nfs@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] NFS: state manager thread must stay running.
Date: Mon, 18 Aug 2014 10:29:19 -0400	[thread overview]
Message-ID: <20140818142919.GB17668@mtj.dyndns.org> (raw)
In-Reply-To: <20140818071457.4b345727@notabene.brown>

Hello, Neil.

On Mon, Aug 18, 2014 at 07:14:57AM +1000, NeilBrown wrote:
> It does.  The manage will even continue after there are no mounts active if
> it is blocked on a non-responding server.
> 
> If there is an outstanding RPC request to a non-responsive server
> then the only way to abort that request is to send SIGKILL to the thread
> which is waiting for the request.
> So if we want things to clean up properly on shutdown it seems best for a
> sigkill to be able to abort that thread.

I see.  I'm not convinced SIGKILL is the right way to communicate
things like this tho.  If this is actually a thing which needs to be
exposed, we'd be a lot better off with an interface which is more to
the point rather than meddling with signals to the manager kernel
thread, which ultimately is an implementation detail.  Given the
requirement, I don't have objections to the patch but the requirement
seems rather lopsided.

Thanks.

-- 
tejun

  reply	other threads:[~2014-08-18 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13  4:08 [PATCH] NFS: state manager thread must stay running NeilBrown
2014-08-17 13:11 ` Tejun Heo
2014-08-17 21:14   ` NeilBrown
2014-08-18 14:29     ` Tejun Heo [this message]
2014-09-17  1:43 ` Trond Myklebust
2014-09-17  3:05   ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140818142919.GB17668@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).