From: Christoph Hellwig <hch@lst.de>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 16/19] pnfs/blocklayout: rewrite extent tracking
Date: Mon, 25 Aug 2014 16:43:40 +0200 [thread overview]
Message-ID: <20140825144340.GA16701@lst.de> (raw)
In-Reply-To: <53FB49D9.1060803@Netapp.com>
On Mon, Aug 25, 2014 at 10:36:09AM -0400, Anna Schumaker wrote:
> Whoa, I like the amount of code you manage to remove in this patch! However, there is a lot going on here. Any way this patch could be split into incremental changes? (it's okay to say "no"!)
The answer really is no - it's a wholesale replacement of three tracking
structures with an integrated one that is managed very differently. The only
thing I had split out ealier where various trivial bug fixes like sector
truncations in code that gets ripped out entirely later, so I decided to
fold those again, which didn't increase the patch size by more than 10 lines.
next prev parent reply other threads:[~2014-08-25 14:43 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <pnfs block layout driver fixes V2>
2014-08-21 16:09 ` Christoph Hellwig
2014-08-21 16:09 ` [PATCH 01/19] nfs: cap request size to fit a kmalloced page array Christoph Hellwig
2014-08-21 16:09 ` [PATCH 02/19] pnfs: do not pass uninitialized lsegs to ->free_lseg Christoph Hellwig
2014-08-21 16:09 ` [PATCH 03/19] pnfs: force a layout commit when encountering busy segments during recall Christoph Hellwig
2014-08-24 17:49 ` Boaz Harrosh
2014-08-24 19:18 ` Christoph Hellwig
2014-08-26 14:10 ` [PATCH] pnfs: Kick a pnfs_layoutcommit_inode on recall Boaz Harrosh
2014-08-26 14:26 ` Trond Myklebust
2014-08-26 14:37 ` Boaz Harrosh
2014-08-26 14:52 ` Boaz Harrosh
2014-08-26 14:55 ` Trond Myklebust
2014-08-26 15:02 ` Boaz Harrosh
2014-08-26 15:24 ` Matt W. Benjamin
2014-08-26 15:36 ` Trond Myklebust
2014-08-26 16:56 ` Boaz Harrosh
2014-08-26 16:59 ` Trond Myklebust
2014-08-26 17:06 ` Boaz Harrosh
2014-08-26 17:54 ` Trond Myklebust
2014-08-26 18:19 ` Boaz Harrosh
2014-08-26 18:34 ` Boaz Harrosh
2014-08-26 18:41 ` Trond Myklebust
2014-08-26 19:46 ` Trond Myklebust
2014-08-27 8:50 ` Boaz Harrosh
2014-08-27 8:22 ` Boaz Harrosh
2014-09-09 0:37 ` [PATCH 03/19] pnfs: force a layout commit when encountering busy segments during recall Trond Myklebust
2014-09-09 5:49 ` Christoph Hellwig
2014-09-09 14:38 ` Trond Myklebust
2014-08-21 16:09 ` [PATCH 04/19] pnfs: don't check sequence on new stateids in layoutget Christoph Hellwig
2014-08-21 16:09 ` [PATCH 05/19] pnfs: retry after a bad stateid error from layoutget Christoph Hellwig
2014-08-21 16:09 ` [PATCH 06/19] pnfs: avoid using stale stateids after layoutreturn Christoph Hellwig
2014-08-21 16:09 ` [PATCH 07/19] pnfs: add flag to force read-modify-write in ->write_begin Christoph Hellwig
2014-09-09 3:50 ` Trond Myklebust
2014-09-09 5:53 ` Christoph Hellwig
2014-09-09 14:41 ` Trond Myklebust
2014-08-21 16:09 ` [PATCH 08/19] pnfs: add return_range method Christoph Hellwig
2014-08-25 13:50 ` Anna Schumaker
2014-08-25 14:09 ` Christoph Hellwig
2014-08-25 14:17 ` Anna Schumaker
2014-08-25 14:20 ` Christoph Hellwig
2014-09-09 3:57 ` Trond Myklebust
2014-08-21 16:09 ` [PATCH 09/19] pnfs: allow splicing pre-encoded pages into the layoutcommit args Christoph Hellwig
2014-08-21 16:09 ` [PATCH 10/19] pnfs/blocklayout: reject pnfs blocksize larger than page size Christoph Hellwig
2014-08-21 16:09 ` [PATCH 11/19] pnfs/blocklayout: improve GETDEVICEINFO error reporting Christoph Hellwig
2014-08-21 16:09 ` [PATCH 12/19] pnfs/blocklayout: plug block queues Christoph Hellwig
2014-08-21 16:09 ` [PATCH 13/19] pnfs/blocklayout: correctly decrement extent length Christoph Hellwig
2015-02-09 6:01 ` NeilBrown
2015-02-09 18:24 ` Christoph Hellwig
2014-08-21 16:09 ` [PATCH 14/19] pnfs/blocklayout: remove read-modify-write handling in bl_write_pagelist Christoph Hellwig
2014-09-09 4:43 ` Trond Myklebust
2014-08-21 16:09 ` [PATCH 15/19] pnfs/blocklayout: don't set pages uptodate Christoph Hellwig
2014-09-09 4:48 ` Trond Myklebust
2014-08-21 16:09 ` [PATCH 16/19] pnfs/blocklayout: rewrite extent tracking Christoph Hellwig
2014-08-25 14:36 ` Anna Schumaker
2014-08-25 14:43 ` Christoph Hellwig [this message]
2014-08-26 9:06 ` Boaz Harrosh
2014-09-09 4:50 ` Trond Myklebust
2014-08-21 16:09 ` [PATCH 17/19] pnfs/blocklayout: implement the return_range method Christoph Hellwig
2014-09-09 4:03 ` Trond Myklebust
2014-08-21 16:09 ` [PATCH 18/19] pnfs/blocklayout: return layouts on setattr Christoph Hellwig
2014-09-09 4:09 ` Trond Myklebust
2014-08-21 16:09 ` [PATCH 19/19] pnfs/blocklayout: allocate separate pages for the layoutcommit payload Christoph Hellwig
2014-09-09 4:52 ` Trond Myklebust
2014-08-21 16:13 ` pnfs block layout driver fixes V2 Christoph Hellwig
2014-09-09 4:12 ` Trond Myklebust
2014-09-09 5:54 ` Christoph Hellwig
2014-09-09 14:40 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825144340.GA16701@lst.de \
--to=hch@lst.de \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).