public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/4] sunrpc: fix byte-swapping of displayed XID
Date: Wed, 27 Aug 2014 17:16:49 -0400	[thread overview]
Message-ID: <20140827211649.GA18393@fieldses.org> (raw)
In-Reply-To: <20140822191050.3883.53374.stgit@klimt.1015granger.net>

On Fri, Aug 22, 2014 at 03:10:50PM -0400, Chuck Lever wrote:
> xprt_lookup_rqst() and bc_send_request() display a byte-swapped XID,
> but receive_cb_reply() does not.

Thanks, applying.--b.

> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
>  net/sunrpc/svcsock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index c24a8ff..6ed8729 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -1036,7 +1036,7 @@ static int receive_cb_reply(struct svc_sock *svsk, struct svc_rqst *rqstp)
>  			"%s: Got unrecognized reply: "
>  			"calldir 0x%x xpt_bc_xprt %p xid %08x\n",
>  			__func__, ntohl(calldir),
> -			bc_xprt, xid);
> +			bc_xprt, ntohl(xid));
>  		return -EAGAIN;
>  	}
>  
> 

  reply	other threads:[~2014-08-27 21:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 19:10 [PATCH 0/4] Simple-minded server fixes for sidecar backchannel Chuck Lever
2014-08-22 19:10 ` [PATCH 1/4] sunrpc: fix byte-swapping of displayed XID Chuck Lever
2014-08-27 21:16   ` J. Bruce Fields [this message]
2014-08-22 19:10 ` [PATCH 2/4] NFSD: Always initialize cl_cb_addr Chuck Lever
2014-10-02 19:53   ` J. Bruce Fields
2014-08-22 19:11 ` [PATCH 3/4] nfsd: Mark back channel down if SESSION4_BACK_CHAN is clear Chuck Lever
2014-08-22 19:11 ` [PATCH 4/4] nfsd: Assert SEQ4_STATUS_CB_PATH_DOWN_SESSION Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140827211649.GA18393@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox