From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
Dan Aloni <dan@kernelim.com>
Subject: Re: [PATCH v2] nfs: fix kernel warning when removing proc entry
Date: Thu, 28 Aug 2014 02:41:23 +0100 [thread overview]
Message-ID: <20140828014123.GF18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <87ppfvrdux.fsf@x220.int.ebiederm.org>
On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote:
> Cong Wang <xiyou.wangcong@gmail.com> writes:
>
> > I saw the following kernel warning:
>
> Cong thanks for finding and tracking this. I was clearly asleep at the
> switch when I was testing my fix to the nfs client code :(
>
> I have applied this patch and will push it to Linus after it has a
> little bit to sit in linux-next.
Why does that code wank with one-by-one remove_proc_entry(), BTW?
remove_proc_subtree("nfsfs", net->proc_net) will take care of the whole pile
just fine, TYVM... While we are it, there's no need to keep ->proc_nfsfs
at all - just have it in a local variable in nfs_fs_proc_net_init().
next prev parent reply other threads:[~2014-08-28 2:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 19:36 [PATCH v2] nfs: fix kernel warning when removing proc entry Cong Wang
2014-08-20 4:20 ` Eric W. Biederman
[not found] ` <alpine.DEB.2.19.4.1408192222470.2758@trent.utfs.org>
2014-08-20 23:16 ` Trond Myklebust
2014-08-20 23:27 ` Trond Myklebust
2014-08-28 1:41 ` Al Viro [this message]
2014-09-08 23:54 ` Trond Myklebust
2014-09-09 2:59 ` Cong Wang
2014-09-08 18:50 ` Matt Mullins
2014-09-08 20:26 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828014123.GF18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dan@kernelim.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).