From: Bruce Fields <bfields@fieldses.org>
To: Boaz Harrosh <openosd@gmail.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Shakil A Khan <shakilk1729@gmail.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
William Andros Adamson <andros@netapp.com>,
Jeffrey Layton <jlayton@primarydata.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Next branch: authgss: authgss.c: Fix warnings for uninitizlized variable expire
Date: Tue, 2 Sep 2014 10:17:39 -0400 [thread overview]
Message-ID: <20140902141739.GB31793@fieldses.org> (raw)
In-Reply-To: <5405CD51.9020601@gmail.com>
On Tue, Sep 02, 2014 at 04:59:45PM +0300, Boaz Harrosh wrote:
> uninitialized_var was made to be a friend not an enemy, in the face of real
> ugliness it is the best we can do. And that is what it should communicate to
> everyone. Why has it become everyone's favorite blasphemy I do not know.
Not personally claiming it should never be used, just that this
particular case is kind of extreme, since unless I'm missing a real
compilication it's basically just:
if (ctx)
assign to expire
...
if (ctx)
use expire
A compiler wouldn't have to be that smart to actually prove to itself
that expire is initialized at the last step, and that it's not only
failing to do that but actually flagging it as possibly unitialized is
weird.
--b.
next prev parent reply other threads:[~2014-09-02 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 11:32 [PATCH] Next branch: authgss: authgss.c: Fix warnings for uninitizlized variable expire Shakil A Khan
2014-09-01 13:50 ` Trond Myklebust
2014-09-02 10:52 ` Boaz Harrosh
2014-09-02 13:21 ` Bruce Fields
2014-09-02 13:59 ` Boaz Harrosh
2014-09-02 14:17 ` Bruce Fields [this message]
2014-09-02 16:05 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902141739.GB31793@fieldses.org \
--to=bfields@fieldses.org \
--cc=andros@netapp.com \
--cc=davem@davemloft.net \
--cc=jlayton@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openosd@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=shakilk1729@gmail.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox