From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nfs@vger.kernel.org
Subject: Re: kernel BUG in fs/dcache.c running nfs
Date: Tue, 9 Sep 2014 08:42:11 -0700 [thread overview]
Message-ID: <20140909154211.GA6614@infradead.org> (raw)
In-Reply-To: <20140909105918.59477ee3@tlielax.poochiereds.net>
On Tue, Sep 09, 2014 at 10:59:18AM -0400, Jeff Layton wrote:
> > [ 5497.405585] [<ffffffff8135d0c1>] nfs4_do_open.constprop.84+0x681/0x960
> > [ 5497.405585] [<ffffffff8135d459>] nfs4_atomic_open+0x9/0x20
> > [ 5497.405585] [<ffffffff8136cc3d>] nfs4_file_open+0xcd/0x1b0
> > [ 5497.405585] [<ffffffff811b8092>] do_dentry_open.isra.13+0x1f2/0x320
> > [ 5497.405585] [<ffffffff811b82ad>] finish_open+0x1d/0x30
> > [ 5497.405585] [<ffffffff811c98e9>] path_openat+0xb9/0x670
> > [ 5497.405585] [<ffffffff811ca26e>] do_filp_open+0x3e/0xa0
> > [ 5497.405585] [<ffffffff811b95cc>] do_sys_open+0x13c/0x230
> > [ 5497.405585] [<ffffffff811b96dd>] SyS_open+0x1d/0x20
> > [ 5497.405585] [<ffffffff81d9f5a9>] system_call_fastpath+0x16/0x1b
> >
>
> Odd...
>
> It looks like you hit the BUG() in d_instantiate.
>
> I don't see any calls to d_instantiate in the current nfs_code (aside
> from the one in nfs_lookup, and I don't think that's getting called
> here). d_instantiate is called by d_add though, and that gets called
> from nfs_atomic_open. Is that what happened here?
>
> Maybe you can use gdb to figure out what line of code
> "nfs4_do_open.constprop.84+0x681" actually is?
My gdb can't cope with these constprop expressions unfortunately.
But when you remove the questionable symbols as I've done above it's
pretty clear that this must be the
nfs4_atomic_open
-> nfs4_do_open
-> _nfs4_do_open
-> _nfs4_open_and_get_state
-> d_add
-> d_instantiate
call chain. There is heavy inlining going on inside nfs4file.c, and
d_add now is a simple inline around d_instantiate and d_rehash.
>
> --
> Jeff Layton <jlayton@primarydata.com>
---end quoted text---
next prev parent reply other threads:[~2014-09-09 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 14:45 kernel BUG in fs/dcache.c running nfs Christoph Hellwig
2014-09-09 14:59 ` Jeff Layton
2014-09-09 15:42 ` Christoph Hellwig [this message]
2014-09-09 16:12 ` Jeff Layton
2014-09-09 16:15 ` Jeff Layton
2014-09-09 17:50 ` Jeff Layton
2014-09-10 3:57 ` NeilBrown
2014-09-10 11:59 ` Jeff Layton
2014-09-11 6:20 ` NeilBrown
2014-09-26 23:08 ` Al Viro
2014-09-29 1:35 ` NeilBrown
2014-09-09 16:59 ` Trond Myklebust
2014-09-09 17:28 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909154211.GA6614@infradead.org \
--to=hch@infradead.org \
--cc=jeff.layton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox