From: Christoph Hellwig <hch@infradead.org>
To: Anna.Schumaker@netapp.com
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/3] nfsd: Add ALLOCATE support
Date: Tue, 9 Sep 2014 08:55:18 -0700 [thread overview]
Message-ID: <20140909155518.GB21928@infradead.org> (raw)
In-Reply-To: <1410274182-30740-3-git-send-email-Anna.Schumaker@Netapp.com>
On Tue, Sep 09, 2014 at 10:49:41AM -0400, Anna.Schumaker@netapp.com wrote:
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
>
> The ALLOCATE operation is used to preallocate space in a file. I use
> vfs_fallocate() to do the actual preallocation.
>
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Looks largely good, but can you do an audit how the error codes match
the spec? E.g. We return -ENODEV in do_fallocate if it's called on
a special file, but that doesn't translate to any valid error codes
for ALLOCATE in the NFSv4.2.
I guess it should be NFSERR_NOTSUPP, and I'll work with Tom to actually
define this case in the spec.
next prev parent reply other threads:[~2014-09-09 15:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 14:49 [PATCH 0/3] NFSD: Add ALLOCATE and DEALLOCATE support Anna.Schumaker
2014-09-09 14:49 ` [PATCH 1/3] VFS: Rename do_fallocate() to vfs_fallocate() Anna.Schumaker
2014-09-09 15:50 ` Christoph Hellwig
2014-09-10 19:43 ` J. Bruce Fields
2014-09-10 22:12 ` Christoph Hellwig
2014-09-09 14:49 ` [PATCH 2/3] nfsd: Add ALLOCATE support Anna.Schumaker
2014-09-09 15:55 ` Christoph Hellwig [this message]
2014-09-09 19:17 ` Anna Schumaker
2014-09-10 20:18 ` J. Bruce Fields
2014-09-10 22:11 ` Christoph Hellwig
2014-09-10 22:26 ` Christoph Hellwig
2014-09-09 14:49 ` [PATCH 3/3] nfsd: Add DEALLOCATE support Anna.Schumaker
2014-09-09 15:56 ` Christoph Hellwig
2014-09-10 20:19 ` J. Bruce Fields
2014-09-10 22:13 ` Christoph Hellwig
2014-09-09 18:13 ` [PATCH 0/3] NFSD: Add ALLOCATE and " Christoph Hellwig
2014-09-09 19:00 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909155518.GB21928@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).