From: Christoph Hellwig <hch@lst.de>
To: Peng Tao <bergwolf@primarydata.com>
Cc: Christoph Hellwig <hch@lst.de>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 7/9] pnfs/blocklayout: implement the return_range method
Date: Thu, 11 Sep 2014 17:24:22 +0200 [thread overview]
Message-ID: <20140911152422.GC6690@lst.de> (raw)
In-Reply-To: <CAKVebiWGsuHTFbCdfQ+=tYakwok5-KPWK7A=zaWmnuJewS+fGg@mail.gmail.com>
On Thu, Sep 11, 2014 at 10:16:56PM +0800, Peng Tao wrote:
> > diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
> > index 42b6f9c..a7524c4 100644
> > --- a/fs/nfs/blocklayout/blocklayout.c
> > +++ b/fs/nfs/blocklayout/blocklayout.c
> > @@ -470,6 +470,35 @@ static struct pnfs_layout_segment *bl_alloc_lseg(struct pnfs_layout_hdr *lo,
> > }
> >
> > static void
> > +bl_return_range(struct pnfs_layout_hdr *lo,
> > + struct pnfs_layout_range *range)
> > +{
> > + struct pnfs_block_layout *bl = BLK_LO2EXT(lo);
> > + sector_t offset = range->offset >> SECTOR_SHIFT, end;
> > + int err;
> > +
> > + if (range->offset % 8) {
> why arbitrary block size? You should be able to use the blocksize
> returned by server, right?
I need to look into it. Right now the client has all extents properly
aligned, and allowing a smaller size here would change that. Give me
some time to test it and get back to you.
>
> btw, did you test your patchset with smaller block size such as 2K/1K?
> Did it work?
I did test a very early version but haven't redone the tests. It worked
fine because even although the server supported smaller blocks the client
now never asks for anything not aligned to 4k!
next prev parent reply other threads:[~2014-09-11 15:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 15:23 pnfs block layout driver fixes V4 Christoph Hellwig
2014-09-10 15:23 ` [PATCH 1/9] pnfs: force a layout commit when encountering busy segments during recall Christoph Hellwig
2014-09-10 15:23 ` [PATCH 2/9] pnfs: add flag to force read-modify-write in ->write_begin Christoph Hellwig
2014-09-10 15:23 ` [PATCH 3/9] pnfs: add return_range method Christoph Hellwig
2014-09-11 13:54 ` Peng Tao
2014-09-11 15:20 ` Christoph Hellwig
2014-09-11 15:30 ` Peng Tao
2014-09-11 15:36 ` Christoph Hellwig
2014-09-12 2:22 ` Peng Tao
2014-09-13 19:38 ` Christoph Hellwig
2014-09-10 15:23 ` [PATCH 4/9] pnfs/blocklayout: remove read-modify-write handling in bl_write_pagelist Christoph Hellwig
2014-09-10 15:23 ` [PATCH 5/9] pnfs/blocklayout: don't set pages uptodate Christoph Hellwig
2014-09-10 15:23 ` [PATCH 6/9] pnfs/blocklayout: rewrite extent tracking Christoph Hellwig
2014-09-11 14:11 ` Peng Tao
2014-09-11 15:21 ` Christoph Hellwig
2014-09-10 15:23 ` [PATCH 7/9] pnfs/blocklayout: implement the return_range method Christoph Hellwig
2014-09-11 14:16 ` Peng Tao
2014-09-11 15:24 ` Christoph Hellwig [this message]
2014-09-10 15:23 ` [PATCH 8/9] pnfs/blocklayout: return layouts on setattr Christoph Hellwig
2014-09-11 14:24 ` Peng Tao
2014-09-11 14:42 ` Boaz Harrosh
2014-09-11 15:25 ` Christoph Hellwig
2014-09-11 15:38 ` Trond Myklebust
2014-09-11 15:48 ` Christoph Hellwig
2014-09-11 16:14 ` Trond Myklebust
2014-09-14 10:55 ` Boaz Harrosh
2014-09-14 13:24 ` Trond Myklebust
2014-09-14 13:51 ` Boaz Harrosh
2014-09-14 14:16 ` Trond Myklebust
2014-09-14 14:28 ` Boaz Harrosh
2014-09-10 15:23 ` [PATCH 9/9] pnfs/blocklayout: allocate separate pages for the layoutcommit payload Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-09-09 16:40 pnfs block layout driver fixes V3 Christoph Hellwig
2014-09-09 16:40 ` [PATCH 7/9] pnfs/blocklayout: implement the return_range method Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911152422.GC6690@lst.de \
--to=hch@lst.de \
--cc=bergwolf@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).